-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DimmerStep
command
#9733
Add DimmerStep
command
#9733
Conversation
@Scoobler I made one small change to your PR which was to change the valid range of |
5d8db70
to
b8abc83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my suggested change it looks ready for merge.
Thx. about to merge. Looking forward to your shelly stuff. |
@jamesturton looks great, from testing even a value of 10 was a very high - but it’s good to give people the option to tune to all the different needs out there! |
Add command ``DimmerStep 1..50`` to change default dimmer up and down step of 10% by James Turton (#9733)
does that still read only or i just can't set it else than 10 ? |
|
yup you are right, i didn't provided much info's, because i thought that this treed is just about DimmerStep.... I just wandered if DimmerStep feature is still "hard-coded" (as i read it once was) to 10 because i tried to change it to 5 or other number, but my rules on long-press which trigger + and - continue to increase or decrease it for a 10 even i let DimmerStep 5 or less so i didn't figured out how to soften that dimming steps, thanks, and i'm not sure what release i used yesterday, but some ver 10xx from special tasmota platinum, but then i tested with "usual" last tasmota and same +/- 10 steps inc/dec. when using rules, thx. |
At least with latest development version:
|
ok, i probably can't use it as i use 4 pwm channels and "normal" dimmer not work for me, so i had to fix rules to use channel1 instead dimmer and it work, but
maybe DimmerStep not work on 4 channel configuration (because has no effect on channels)
this now hardly exits from thread but if someone can point me how to use local longpress rules for channels but with DimmerStep having effect on individual or global channels thx :) |
Signed-off-by: Scoobler [email protected]
Description:
Add
DimmerStep
to allow an auto (+/-) value to be set between 1...50 instead of the fixed value of 10 which creates a very quick step when using rules for dimming. Default value remains 10.Related issue (if applicable): fixes #9669
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass