Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENERGY.Period after midnight #9536

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

gominoa
Copy link
Contributor

@gominoa gominoa commented Oct 13, 2020

ENERGY.Period incorrectly shows 0 for the first teleperiod after midnight

Description:

Below is a Grafana of ENERGY.Period with teleperiod of 60. The data is cleared at midnight, which results in Period incorrectly reporting 0 at the next teleperiod due to the if check in EnergyShow. Remove the if check because Energy.period is always valid with the revised calculation.

I've been running this patch for a couple weeks with no ill effects.

ENERGYPeriod

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.3
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

ENERGY.Period incorrectly shows 0 for the first teleperiod after midnight
@arendst arendst merged commit bd31581 into arendst:development Oct 15, 2020
@ascillato2 ascillato2 added the hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants