Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ORNO WE-517 Modbus Power Meter #9353

Closed

Conversation

maximevince
Copy link

@maximevince maximevince commented Sep 20, 2020

Description:

This PR adds support for the ORNO WE-517 3-phase power meter with modbus.
By connecting a UART <-> RS485 converter to the Serial RX/TX lines, Tasmota can read out the meter.

I used 8E1 as the serial power config. I am not sure if this is support by SoftwareSerial?
It might only work on the hardware serial port now.

Also, I have no ESP32 to test, so only ESP8266 was tested.

Related issue (if applicable): No related issue, this is support for a new power meter.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.1
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

Jason2866 commented Sep 20, 2020

CI fail in Tasmota32 sensors /home/runner/work/Tasmota/Tasmota/tasmota/xnrg_17_ornowe517.ino:183:39: error: 'GPIO_WE517_RX' was not declared in this scope
Working okay if you can not test but compilation has to be successful

@maximevince
Copy link
Author

CI fail in Tasmota32 sensors /home/runner/work/Tasmota/Tasmota/tasmota/xnrg_17_ornowe517.ino:183:39: error: 'GPIO_WE517_RX' was not declared in this scope
Working okay if you can not test but compilation has to be successful

Okay thanks, the issue is fixed now. All checks passing.

@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Sep 21, 2020
@arendst
Copy link
Owner

arendst commented Sep 21, 2020

See here #9237 (comment) why on hold

arendst added a commit that referenced this pull request Oct 2, 2020
Add optional support for Orno WE517-Modbus energy meter by Maxime Vincent (#9353)
@arendst
Copy link
Owner

arendst commented Oct 2, 2020

Thx. Just merged with needed changes.

@arendst arendst closed this Oct 2, 2020
@maximevince
Copy link
Author

Awesome! 👍

@Bitfriemler22
Copy link

I like the driver very much. The meter is perfect for my use and the driver does everything that is needed, thanks maximevince.
But I found a minor typo in xnrg_17_ornowe517.ino: The address for "Phase 2 volt amps reactive" shall be "0x0028".

@maximevince
Copy link
Author

I like the driver very much. The meter is perfect for my use and the driver does everything that is needed, thanks maximevince. But I found a minor typo in xnrg_17_ornowe517.ino: The address for "Phase 2 volt amps reactive" shall be "0x0028".

Thanks for noticing!
I have created an additional pull request with the fix here:
#14841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants