Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialsend6 - comma-separated decimal send as binary #8937

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

grob6000
Copy link
Contributor

@grob6000 grob6000 commented Jul 20, 2020

Description:

Alternative to #8920 (i.e. one or the other). Same use case - allowing sending of parameters using rules to binary serial devices e.g. #5737. I've noted that the mqtt response formats in HEX when serial is received after a binary message is sent - I don't think this should change so it's treated the same.

example: serialsend6 255,85,5,5,220,10

An example rule that (should) allow the above device to work with vanilla tasmota + this PR:
rule1
on dimmer#state=0 do event setdimmer=5 endon
on dimmer#state>0 do backlog scale1 %value%,1,100,16,255; event udimmer endon
on dimmer#boot do backlog baudrate 9600; scale1 %value%,1,100,16,255; event udimmer endon
on event#udimmer do event setdimmer=%var1% endon
on event#setdimmer do serialsend6 255,85,%value%,5,220,10 endon
on power1#state=0 do event setdimmer=5 endon
on power1#state=1 do event setdimmer=%var1% endon

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.2.1
  • The code change is tested and works on core ESP32 V.1.12.2

no device to test sorry

  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

grob6000 added 3 commits July 19, 2020 20:34
* Adds serialsend6, allowing sending of binary data with comma-delimited string of decimal numbers.
Forgot to fix top condition
@arendst
Copy link
Owner

arendst commented Jul 20, 2020

Thx. Will evaluate

@arendst arendst self-assigned this Jul 20, 2020
@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Jul 20, 2020
@arendst arendst merged commit ac780d5 into arendst:development Jul 21, 2020
arendst added a commit that referenced this pull request Jul 21, 2020
Add command (``S``)``SerialSend6`` \<comma seperated values\> (#8937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants