Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LMT01 temperature sensor #8713

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Add support for LMT01 temperature sensor #8713

merged 2 commits into from
Jun 17, 2020

Conversation

justifiably
Copy link
Contributor

Description:

Proposed support for TI's LMT01 two-wire temperature sensor IC. This IC boasts good accuracy and a wider range compared with other ICs. It needs a single GPIO to interface. I have tested with digital GPIO on ESP8266 using a transistor driver as shown in the datasheet. The chip might also work with only a resistor and the analogue input with a threshold but I haven't tried that. Also, the datasheet suggests the use of a look-up table to improve the accuracy at the edges of the range, this might be worth adding but would cost a few more bytes.

The code is very simple, I'm happy to put in public domain or remove my moniker from the copyright.

I've tried to mimic the other drivers, please review. It compiles against ESP32 but I haven't tested it on one.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core ESP8266 V.2.7.1
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@ascillato
Copy link
Contributor

Hi,

The tests failed due to it is missing the:

#define D_SENSOR_LMT01_PULSE   "LMT01 Pulse"

in language files.

Please, add it to them.

Thanks.

Copy link
Contributor

@ascillato ascillato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Missing key in language files. Please add it to them. Thanks.

@arendst arendst merged commit ec7bad1 into arendst:development Jun 17, 2020
@justifiably
Copy link
Contributor Author

Thanks for accepting so swiftly, great!

@justifiably justifiably deleted the LMT01 branch June 17, 2020 15:04
@ascillato
Copy link
Contributor

Thank you for sharing it! 👍

@arendst
Copy link
Owner

arendst commented Jun 17, 2020

Could you add some documentation to the documentation site. Especially the supported hardware connection. Thank you.

@ascillato
Copy link
Contributor

ascillato commented Jun 17, 2020

@justifiably Docs are at https://tasmota.github.io/docs/ and if you click on the pencil on the top right of the page, you can edit any page and post a PR. Thanks.

arendst added a commit that referenced this pull request Jun 17, 2020
Add support for single wire LMT01 temperature Sensor by justifiably (#8713)
@justifiably
Copy link
Contributor Author

Happy to add some docs.

@hallard
Copy link
Contributor

hallard commented Jun 18, 2020

@ascillato the link you gave for the documentation fire a 404 :-)

@ascillato
Copy link
Contributor

@hallard

Fixed. Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants