HP303B Sensor support #8638

rjaakke · 2020-06-07T14:56:12Z

Description:

Adds support for the HP303B Barometric Pressure Sensor.
I used the Lolin barometric pressure sensor shield.

The default Lolin driver returns an int32 measurement, I modified the driver to return a float for more precise results.

An ESP32 is on its way in the mail, I will test it as soon as it arrives.

Checklist:

The pull request is done against the latest dev branch
Only relevant files were touched
Only one feature/fix was added per PR.
The code change is tested and works on core ESP8266 V.2.7.1
The code change is tested and works on core ESP32 V.1.12.2
I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

tasmota/xsns_73_hp303b.ino

device111 · 2020-06-07T19:17:13Z

@rjaakke
have a look on some other temp/hum sensors for standarized implementation in tasmota.
(BMP, DHT12, AHTX, HIH6130, a.s.o)
specifically reading functions of every second and initialization of sensor.
thanks

device111 · 2020-06-07T20:27:23Z

@rjaakke
and please use structs for global variables.

# Conflicts: # tasmota/support_features.ino Resolved # tools/decode-status.py Resolved

rjaakke · 2020-06-08T08:22:59Z

@rjaakke
and please use structs for global variables.

Resolved

rjaakke · 2020-06-08T08:23:25Z

@rjaakke
have a look on some other temp/hum sensors for standarized implementation in tasmota.
(BMP, DHT12, AHTX, HIH6130, a.s.o)
specifically reading functions of every second and initialization of sensor.
thanks

Should be correct now, please review

device111 · 2020-06-08T12:59:22Z

your on the right way, but you have killed a lot of code for support of 2 Sensors. At the moment, only one Sensor is detected.
Have a look in the mcp9808 code for init multible I2C adresses.
And if you want, make a correction of the begin() function in the libary, that can give you return a true or false for succesfull initialisation. The init() call in begin() gaves you the return codes for that.

rjaakke · 2020-06-08T18:40:34Z

your on the right way, but you have killed a lot of code for support of 2 Sensors. At the moment, only one Sensor is detected.
Have a look in the mcp9808 code for init multible I2C adresses.
And if you want, make a correction of the begin() function in the libary, that can give you return a true or false for succesfull initialisation. The init() call in begin() gaves you the return codes for that.

Ok, should work on all I2C addresses now, I also modified the LOLIN lib to return a status when calling begin().

device111 · 2020-06-09T06:03:56Z

tasmota/xsns_73_hp303b.ino

-    if (I2cActive(bhp303b_addresses[i])) { return; }
-
-    bhp303b_sensor.address = bhp303b_addresses[i];
+    if (I2cActive(HP303B_START_ADDRESS + i)) { return; }



us continue to stay in the loop and use I2cSetDevice:
if (!I2cSetDevice(HP303B_START_ADDRESS + i )) { continue; }

Fixed it.

It was unclear to me which one of the two to use as I found both implementations in different sensors.

device111 · 2020-06-09T06:04:19Z

tasmota/xsns_73_hp303b.ino

-      bhp303b_sensor.type = 1;
+      hp303b_sensor[hp303b_cfg.count].address = HP303B_START_ADDRESS + i;
+      I2cSetActiveFound(hp303b_sensor[hp303b_cfg.count].address, hp303b_cfg.types);
+      hp303b_cfg.count++;
      break;


we don't need to break

device111 · 2020-06-09T06:04:29Z

tasmota/xsns_73_hp303b.ino

+    strlcpy(sensor_name, hp303b_cfg.types, sizeof(sensor_name));
+    if (hp303b_cfg.count > 1) {
+      snprintf_P(sensor_name, sizeof(sensor_name), PSTR("%s%c0x%02X"), sensor_name, IndexSeparator(), hp303b_sensor[i].address); // MCP9808-18, MCP9808-1A  etc.
+    }


check all the comments. Some are from MCP9808

device111 · 2020-06-09T06:04:34Z

tasmota/xsns_73_hp303b.ino

+      char str_pressure[33];
+      dtostrfd(hp303b_sensor[i].pressure, Settings.flag2.pressure_resolution, str_pressure);
+
+      if (json)


quote from Theo:
domoticz and knx only support one temp sensor index you'l need to add a test for loop index 0 here. See latest change in bh1750.

Check and comments added.

ok, now we have tasmota support of 2 Sensors, but not yet in the libary.

you must change the libary to support reading functions with different I2C addresses.
at the moment, we have only support of one sensor with fix I2c reading functions in the libary.
i.e:
HP303BSensor.measureTempOnce(t, hp303b_cfg.oversampling);
(reads only from the address that was last initialized)

Now, we need a index for the reading functions:
HP303BSensor.measureTempOnce(hp303b_sensor[hp303b_idx].address, t, hp303b_cfg.oversampling);

the local variable for i2c address in the libary is m_slaveAddress
i can help you to change the libary, if you want.

Ps.: good example is the MCP9808 Libary...

I'm gonna make an attempt but I could use some advice.

Since I'm rewriting the library for Tasmota, do you think I should remove the continuous and interrupt code from the lib to reduce size?

The library also support SPI but I don't know how to test this, is this useful for Tasmota or should remove it?

no, you don't must remove the code for SPI or other functions. The compiler compile only used functions, so there is no Advantage and you save no space. you don' must complete re-write the libary.
We need only the 2 little changes and all should work.
But feel free to do it...

you must change only the 2 functions:
measureTempOnce() and
measurePressureOnce()

add a Parameter for I2c-address in both functions and all is working with tasmota.
(note: each function of both is overloaded with 2 different Parameters)

example for temp:
int16_t LOLIN_HP303B::measureTempOnce(uint8_t slaveAddress, int32_t &result) { return measureTempOnce(slaveAddress, result, m_tempOsr); }
and
int16_t LOLIN_HP303B::measurePressureOnce(uint8_t slaveAddress; int32_t &result, uint8_t oversamplingRate) { m_slaveAddress = slaveAddress; //start the measurement .......

should work.

don't forget to change the defines in header file...

ah ok, thats bad with the m_initFail and m_opMode
variables.
I have a look tomorrow for it...
I hope, this is not a big Problem..

or you make the implementation of more I2c addresses in a second Step.
You can change #define HP303B_MAX_SENSORS 2
to 1 and do first a PR in Tasmota.

ok, the m_initFail is not a Problem. you can delete the check of this variable from reading function, we have checked the init with the begin() function.
The m_opMode needs a little bit more investigation.

@arendst
can you please check the driver as it is and you can merge it?

With the change #define HP303B_MAX_SENSORS 1, the driver should work with one sensor for now.
the support for two sensors comes later.
thanks in Advance.

I committed the change to the lib. It would be strange if you connect 2 sensors and have them running in different operation mode. So this should not be an issue

device111 · 2020-06-10T18:06:50Z

ok, but if you have only one sensor connected, the last m_initFail fail and the var hold the state.
so you must delete the query of m_initFail in the Reading function startMeasureTempOnce()

the libary check in the reading functions if the sensor ist success init but we check this with the begin function and give it back to Tasmota driver.

rjaakke · 2020-06-10T19:56:10Z

Ok, fixed it.

device111 · 2020-06-10T21:16:13Z

ok, have you tested if all working now?

rjaakke · 2020-06-11T07:07:42Z

ok, have you tested if all working now?

Yes, the sensor works but I only have one sensor shield to test with.

device111 · 2020-06-11T07:53:20Z

Good Job!
last test: Can you test the sensor with the second I2C address?
If all working, we must wait for Theo, that have a look above the Code and merge the PR.

rjaakke · 2020-06-11T19:11:25Z

Good Job!
last test: Can you test the sensor with the second I2C address?
If all working, we must wait for Theo, that have a look above the Code and merge the PR.

I tried getting the sensor shield to use the other 0x76 address but for some reason I can't get it to work. I also tried the library examples but with the same result. It seems to be an issue with the shield.

Here's the info:
https://docs.wemos.cc/en/latest/d1_mini_shiled/barometric_pressure.html#arduino

I tried connecting the jumper, tried to connect the jumper to ground with a 4.7k resistor but no luck.

# Conflicts: # tasmota/support_features.ino Resolved # tools/decode-status.py Resolved

device111 · 2020-06-11T19:59:27Z

i don't know this board, i have seen no jumper on it. have you wired this two Points?:

rjaakke · 2020-06-11T20:05:29Z

i don't know this board, i have seen no jumper on it. have you wired this two Points?:

Yes, I also tried to wire the SDO on the chip directly to GRND but without luck.

device111 · 2020-06-11T20:11:01Z

Have you tried to wire the sensor and make a I2Cscan in Tasmota? Is the 0x76 address found?
If not, something is wrong with the board.
But Driver works now with Tasmota and Theo can check it.

rjaakke · 2020-06-11T20:13:09Z

Have you tried to wire the sensor and make a I2Cscan in Tasmota? Is the 0x76 address found?
If not, something is wrong with the board.
But Driver works now with Tasmota and Theo can check it.

Yes, I also tried the basic samples that come with the library and they couldn't find the sensor at 0x76 either.

arendst · 2020-06-12T09:51:30Z

Thx.

Add support for HP303B Temperature and Pressure sensor by Robert Jaakke (#8638)

BytesOnline · 2020-08-06T20:10:05Z

How can this device be used?

The scan finds a device:
stat/tasmota_24B1D5/RESULT = {"I2CScan":"Device(s) found at 0x77"}

But which driver is this or how can I enable it?

rjaakke added 5 commits June 5, 2020 20:27

Merge branch 'development' into HP303B

344d544

Working sample

6667951

switched to float values and converted Pa to hPa

2da0952

Changed driver to measure float

d3a59fd

Merge branch 'development' into HP303B

caa539e

device111 reviewed Jun 7, 2020

View reviewed changes

tasmota/xsns_73_hp303b.ino Show resolved Hide resolved

rjaakke added 4 commits June 8, 2020 08:58

Mover begin() to detect function

aa5587f

Merge branch 'development' into HP303B

601317d

# Conflicts: # tasmota/support_features.ino Resolved # tools/decode-status.py Resolved

Moved global variables to struct

d6e1ecb

refactored implementation

abfa4f4

arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Jun 8, 2020

rjaakke added 2 commits June 8, 2020 20:37

Added support for multiple i2c addresses

92643e8

Merge branch 'development' into HP303B

d2815c5

ghost approved these changes Jun 8, 2020

View reviewed changes

device111 reviewed Jun 9, 2020

View reviewed changes

rjaakke added 3 commits June 9, 2020 09:14

Resolved review comments

9d2d225

Added option to set i2c address in measure...Once in lib

325564f

Merge branch 'development' into HP303B

ec247f7

Removed m_initFail check because we moved it to begin()

8cbb35e

Merge branch 'development' into HP303B

9835c55

# Conflicts: # tasmota/support_features.ino Resolved # tools/decode-status.py Resolved

arendst merged commit 7919678 into arendst:development Jun 12, 2020

arendst added a commit that referenced this pull request Jun 12, 2020

Add support for HP303B

03cd543

Add support for HP303B Temperature and Pressure sensor by Robert Jaakke (#8638)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HP303B Sensor support #8638

HP303B Sensor support #8638

rjaakke commented Jun 7, 2020

device111 commented Jun 7, 2020 •

edited

Loading

device111 commented Jun 7, 2020

rjaakke commented Jun 8, 2020

rjaakke commented Jun 8, 2020

device111 commented Jun 8, 2020

rjaakke commented Jun 8, 2020

device111 Jun 9, 2020

rjaakke Jun 9, 2020

device111 Jun 9, 2020

rjaakke Jun 9, 2020

device111 Jun 9, 2020

rjaakke Jun 9, 2020

device111 Jun 9, 2020

rjaakke Jun 9, 2020

device111 Jun 9, 2020 •

edited

Loading

rjaakke Jun 9, 2020

device111 Jun 9, 2020

device111 Jun 9, 2020

device111 Jun 9, 2020

device111 Jun 9, 2020

device111 Jun 10, 2020

rjaakke Jun 10, 2020

device111 commented Jun 10, 2020

rjaakke commented Jun 10, 2020

device111 commented Jun 10, 2020

rjaakke commented Jun 11, 2020

device111 commented Jun 11, 2020

rjaakke commented Jun 11, 2020

device111 commented Jun 11, 2020

rjaakke commented Jun 11, 2020

device111 commented Jun 11, 2020

rjaakke commented Jun 11, 2020

arendst commented Jun 12, 2020

BytesOnline commented Aug 6, 2020

HP303B Sensor support #8638

HP303B Sensor support #8638

Conversation

rjaakke commented Jun 7, 2020

Description:

Checklist:

device111 commented Jun 7, 2020 • edited Loading

device111 commented Jun 7, 2020

rjaakke commented Jun 8, 2020

rjaakke commented Jun 8, 2020

device111 commented Jun 8, 2020

rjaakke commented Jun 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

device111 Jun 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

device111 commented Jun 10, 2020

rjaakke commented Jun 10, 2020

device111 commented Jun 10, 2020

rjaakke commented Jun 11, 2020

device111 commented Jun 11, 2020

rjaakke commented Jun 11, 2020

device111 commented Jun 11, 2020

rjaakke commented Jun 11, 2020

device111 commented Jun 11, 2020

rjaakke commented Jun 11, 2020

arendst commented Jun 12, 2020

BytesOnline commented Aug 6, 2020

device111 commented Jun 7, 2020 •

edited

Loading

device111 Jun 9, 2020 •

edited

Loading