Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DimmerRange for PWM lights (#8120) #8160

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

s-hadinger
Copy link
Collaborator

Description:

DimmerRange is now applied to PWM lights. This allows to set a minimum PMW value for non-zero levels. This is required for PMW_DIMMER and Mi Desk Lamp.

DimmerRange levels are 0..100 and gamma correction is applied if required.

To set the minimum value, set one channel to max value, ex: Color FF0000 then use Dimmer <x> to reduce brightness until the light turns off, and set DimmerRange to this value + 1. With LedTable 1, the minimum value is usually 35-40.

Related issue (if applicable): fixes #8120

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core Tasmota_core_stage
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 4ff2e5d into arendst:development Apr 13, 2020
@s-hadinger s-hadinger deleted the dimmerrange_pwm branch January 6, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MI Desk Lamp: Erratic led brightness
2 participants