-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build entry for core 2.4.2.... #6664
Conversation
because there are many unsolved issues (bugs) in this cores. The core 2.3.0 and core pre 2.6 are better. Users should not use core 2.4.2 and 2.5.2 for Tasmota anymore.
Let's keep this one open and find out who benefits from 2.4.2 I was using 2.4.2 for over a year as it worked better than 2.3.0 and still kept the amount of code space low. At least lower than 2.5.2 and pre-2.6.0 I have to admit I'm now on pre-2.6.0 for some months but I have to remove functionality to stay below 500k image size. |
I guess removing support for 2.5.2 would be OK. |
Lets remove 2.5.2 |
Remove support for core 2.5.2 (#6664)
I agree to remove them, or at least to remove them from the precompiled bins in thehackbox, leaving just 2.6.0 and 2.3.0. In Discord some users had those weird issues with 2.5.2, and others with 2.4.2 can't use the sleep function to reduce heat on those sonoff basics with problems in the regulator. And they move to 2.3.0 or pre2.6.0 for solving their issues. May be, we can leave those options in platformio.ini just for anyone tinkering, but just offering precompiled bins with the stable 2.3.0 and with the fast 2.6.0 |
Just removed 2.5.2 from platformio. For pre-compiled binaries we need Andre to update his binaries scripts |
I'm also still using 2.4.2 on permanent devices - I'll meddle with pre-2.6 over the next few months but I don't think I'm quite ready to drop 2.4.2 completely. |
2.4.2 and up patches the Krack exploit. Shouldn't that core at least be supported until 2.6.x is actually released? |
@TimelessNL Krack exploit is the minor issue. See #6348 This only fixed in pre 2.6 |
Are you sure? Here 2.4.2 is also stated to solve krack. Are we talking about the same thing? Because Krack is about the WPA2 exploit and be able to sniff traffic. I don't see that as a 'minor' issue. |
There are more security risks on those cores (2.3.0, 2.4.x, 2.5.x). See #6348 The only core that solves all those risks + solves wifi bugs is the actual arduino stage core. So, the best option is to compile Tasmota under pre2.6.0. That is why is the default option in platformio.ini. This pre2.6.0 has been tested a lot and works really good and really fast. |
Next "nice" one: #6666 |
Adding more info. Core 2.3.0 and core 2.4.2 has a nasty security RISK. See #6666 We should drop all cores and only use pre2.6.0 (at least for precompiled bins and release versions) What about making a new release due this nasty security risk? and offering precompiled bins only with pre2.6.0? |
#6666 ? Srsly? |
I'm OK with only doing dev bins on pre-2.6 if @arendst approves. |
Ok with me too. |
Summary of problems of arduino cores we know so far:
Slow
Faster than 2.3.0
Faster than 2.3.0
Faster than 2.3.0
Faster than 2.3.0 So, We should drop all cores and only use pre2.6.0 (at least for precompiled bins and release versions) (we can leave the entries in platformio.ini with a comment of the flaws) What about making a new release due this nasty security risk? and offering precompiled bins only with pre2.6.0? |
@arendst @ascillato Done - only one OTA path now http://thehackbox.org/tasmota/ |
Closing this PR in favour of #6667 |
because there are many unsolved issues (bugs) in this core.
The core 2.3.0 and core pre 2.6 are better.
Users should not use core 2.4.2 for Tasmota anymore.
Edit since 2.5.2 is already removed
Description:
Fixes weird wifi errors
Checklist: