Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build entry for core 2.4.2.... #6664

Closed
wants to merge 3 commits into from
Closed

Remove build entry for core 2.4.2.... #6664

wants to merge 3 commits into from

Conversation

Jason2866
Copy link
Collaborator

@Jason2866 Jason2866 commented Oct 16, 2019

because there are many unsolved issues (bugs) in this core.
The core 2.3.0 and core pre 2.6 are better.
Users should not use core 2.4.2 for Tasmota anymore.

Edit since 2.5.2 is already removed

Description:

Fixes weird wifi errors

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.3.0, 2.4.2, 2.5.2, and pre-2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

because there are many unsolved issues (bugs) in this cores.
The core 2.3.0 and core pre 2.6 are better. 
Users should not use core 2.4.2 and 2.5.2 for Tasmota anymore.
@arendst
Copy link
Owner

arendst commented Oct 16, 2019

Let's keep this one open and find out who benefits from 2.4.2

I was using 2.4.2 for over a year as it worked better than 2.3.0 and still kept the amount of code space low. At least lower than 2.5.2 and pre-2.6.0

I have to admit I'm now on pre-2.6.0 for some months but I have to remove functionality to stay below 500k image size.

@arendst arendst added the awaiting feedback Action - Waiting for response or more information label Oct 16, 2019
@arendst
Copy link
Owner

arendst commented Oct 16, 2019

I guess removing support for 2.5.2 would be OK.

@Jason2866
Copy link
Collaborator Author

Lets remove 2.5.2
pre 2.6. is based on 2.5.2 with fixed errors and enhancements.
Generated firmware size is smaller than with 2.5.2

arendst added a commit that referenced this pull request Oct 16, 2019
Remove support for core 2.5.2 (#6664)
@ascillato
Copy link
Contributor

ascillato commented Oct 16, 2019

I agree to remove them, or at least to remove them from the precompiled bins in thehackbox, leaving just 2.6.0 and 2.3.0. In Discord some users had those weird issues with 2.5.2, and others with 2.4.2 can't use the sleep function to reduce heat on those sonoff basics with problems in the regulator. And they move to 2.3.0 or pre2.6.0 for solving their issues.

May be, we can leave those options in platformio.ini just for anyone tinkering, but just offering precompiled bins with the stable 2.3.0 and with the fast 2.6.0

@arendst
Copy link
Owner

arendst commented Oct 16, 2019

Just removed 2.5.2 from platformio.

For pre-compiled binaries we need Andre to update his binaries scripts

@Jason2866 Jason2866 changed the title Remove build entrys for core 2.4.2 and 2.5.2.... Remove build entry for core 2.4.2.... Oct 16, 2019
@andrethomas
Copy link
Contributor

I'm also still using 2.4.2 on permanent devices - I'll meddle with pre-2.6 over the next few months but I don't think I'm quite ready to drop 2.4.2 completely.

@TimelessNL
Copy link

2.4.2 and up patches the Krack exploit. Shouldn't that core at least be supported until 2.6.x is actually released?

@Jason2866
Copy link
Collaborator Author

Jason2866 commented Oct 16, 2019

@TimelessNL Krack exploit is the minor issue. See #6348 This only fixed in pre 2.6
So ALL cores prior pre 2.6 are unsave to use...

@TimelessNL
Copy link

TimelessNL commented Oct 16, 2019

Are you sure? Here 2.4.2 is also stated to solve krack. Are we talking about the same thing? Because Krack is about the WPA2 exploit and be able to sniff traffic. I don't see that as a 'minor' issue.

@ascillato
Copy link
Contributor

ascillato commented Oct 16, 2019

There are more security risks on those cores (2.3.0, 2.4.x, 2.5.x). See #6348

The only core that solves all those risks + solves wifi bugs is the actual arduino stage core.

So, the best option is to compile Tasmota under pre2.6.0. That is why is the default option in platformio.ini.

This pre2.6.0 has been tested a lot and works really good and really fast.

@Jason2866
Copy link
Collaborator Author

Jason2866 commented Oct 16, 2019

Next "nice" one: #6666
Time not to use anything else than pre 2.6.
(All my devices are since some month ago on pre 2.6....)

@ascillato
Copy link
Contributor

Adding more info. Core 2.3.0 and core 2.4.2 has a nasty security RISK. See #6666

We should drop all cores and only use pre2.6.0 (at least for precompiled bins and release versions)

@arendst @andrethomas

What about making a new release due this nasty security risk? and offering precompiled bins only with pre2.6.0?

@andrethomas
Copy link
Contributor

#6666 ? Srsly?

@andrethomas
Copy link
Contributor

I'm OK with only doing dev bins on pre-2.6 if @arendst approves.

@arendst
Copy link
Owner

arendst commented Oct 16, 2019

Ok with me too.

@ascillato2
Copy link
Collaborator

ascillato2 commented Oct 16, 2019

Summary of problems of arduino cores we know so far:

  • 2.3.0

Slow
High RAM usage
No software serial support
Sleep feature works
KRACK security issue
blank password security issue(#6666) and others (#6348).
Alexa support works

  • 2.4.2

Faster than 2.3.0
More free RAM than 2.3.0
Software serial support
Sleep feature don't work.
KRACK solved
blank password security issue(#6666) and others (#6348).
Alexa support don't works without a patch. (patch included automatically on Tasmota)

  • 2.5.0 and 2.5.1

Faster than 2.3.0
More free RAM than 2.3.0
Software serial support
Sleep feature don't work
KRACK solved
blank password security issue solved
other security issues not solved(#6348)
Memory manager not in IRAM producing weird issues like reboots.
Alexa support don't works without a patch. (patch included automatically on Tasmota)

  • 2.5.2

Faster than 2.3.0
More free RAM than 2.3.0
Software serial support
Sleep feature work
KRACK solved
blank password security issue solves
other security issues not solved(#6348)
Memory manager not in IRAM producing weird issues like reboots.
Alexa support works.

  • pre2.6.0 and STAGE

Faster than 2.3.0
More free RAM than 2.3.0
Software serial support
Sleep feature work
KRACK solved
blank password security issue solved and others solved(#6348)
Memory manager solved.
Alexa support works.

So,

We should drop all cores and only use pre2.6.0 (at least for precompiled bins and release versions) (we can leave the entries in platformio.ini with a comment of the flaws)

@arendst @andrethomas

What about making a new release due this nasty security risk? and offering precompiled bins only with pre2.6.0?

@Jason2866 Jason2866 mentioned this pull request Oct 16, 2019
@andrethomas
Copy link
Contributor

@arendst @ascillato Done - only one OTA path now http://thehackbox.org/tasmota/

@ascillato2
Copy link
Collaborator

Closing this PR in favour of #6667

@ascillato2 ascillato2 closed this Oct 16, 2019
@ascillato2 ascillato2 removed the awaiting feedback Action - Waiting for response or more information label Oct 16, 2019
@Jason2866 Jason2866 deleted the patch-3 branch October 16, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants