Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preliminary SCD30 support #5434

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Conversation

Frogmore42
Copy link
Contributor

Description:

Related issue (if applicable): fixes #3119

Checklist:

  • The pull request is done against the dev branch
  • Only relevant files were touched (Also beware if your editor has auto-formatting feature enabled)
  • Only one feature/fix was added per PR.
  • The code change is tested and works.
  • The code change pass travis tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Mar 10, 2019

Nice work using available hooks correctly.

@arendst arendst merged commit 7488a49 into arendst:development Mar 10, 2019
arendst added a commit that referenced this pull request Mar 10, 2019
 * Add support for sensor SCD30 (#5434)
 * Add support for commands in sensor drivers
@Frogmore42
Copy link
Contributor Author

Should it have a different sensor number?
It is in the user defined group right now.

@arendst
Copy link
Owner

arendst commented Mar 10, 2019

Already changed in the latest update.

engrbm87 pushed a commit to engrbm87/Sonoff-engrbm that referenced this pull request Mar 11, 2019
 * Add support for sensor SCD30 (arendst#5434)
 * Add support for commands in sensor drivers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of SCD30 I2C CO2 Sensor
2 participants