Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDNS.update(); #4951

Merged
merged 2 commits into from
Jan 17, 2019
Merged

MDNS.update(); #4951

merged 2 commits into from
Jan 17, 2019

Conversation

araczkowski
Copy link
Contributor

Fixes #4938

tested on core 2.3.0, 2.4.2 and 2.5.0
👍

@arendst
Copy link
Owner

arendst commented Jan 16, 2019

Fails Travis as the change needs to be between ifdefs for mdns check.

@araczkowski
Copy link
Contributor Author

OK - I see
#ifdef USE_DISCOVERY
#ifdef WEBSERVER_ADVERTISE

one moment...

@arendst arendst merged commit 726ec46 into arendst:development Jan 17, 2019
arendst added a commit that referenced this pull request Jan 17, 2019
 * Fix mDNS addService (#4938, #4951)
 * Add (S)SerialSend3 escape sequence \x to allow hexadecimal byte value (#3560, #4947)
 * Add SerialBridge command SSerialSend5 <hexdata>
gemu2015 pushed a commit to gemu2015/Sonoff-Tasmota that referenced this pull request Jan 27, 2019
gemu2015 pushed a commit to gemu2015/Sonoff-Tasmota that referenced this pull request Jan 27, 2019
 * Fix mDNS addService (arendst#4938, arendst#4951)
 * Add (S)SerialSend3 escape sequence \x to allow hexadecimal byte value (arendst#3560, arendst#4947)
 * Add SerialBridge command SSerialSend5 <hexdata>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants