Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2S bugfix: webradio crash with invalid url #21446

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

Staars
Copy link
Contributor

@Staars Staars commented May 20, 2024

Description:

It has always be guaranteed to get a crash by providing an invalid url to the web radio command like:
i2swr i_am_not_a_valid_webradio_url

This did of course also include copy-paste-errors or former correct url names.
Besides every other occasional connection error did lead to a crash too.

  1. Main problem was the audio library, which did no error checking.
    Addditionally we check now for success in Tasmota as this is possible with this library change.

  2. Removal of some unused code.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit e7f69eb into arendst:development May 20, 2024
59 checks passed
@Staars Staars deleted the i2s branch May 21, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants