Adding support for MAX17043 Lipo battery-gauge #18739

Vincent1964 · 2023-05-29T14:12:12Z

Description:

This PR contains a sensor driver for MAX17043 a battery gauge for 3.7 Volt batteries. Allows to monitor a battery powered ESP.

Related issue (if applicable): fixes - NONE

Checklist:

The pull request is done against the latest development branch
Only relevant files were touched
Only one feature/fix was added per PR and the code change compiles without warnings
The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
The code change is tested and works with Tasmota core ESP32 V.2.0.9
I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Vincent1964 · 2023-05-29T14:12:48Z

First PR, hope I did everything the way it should be.

Vincent1964

already fixed by: 18737

.vscode/settings.json

arendst · 2023-05-29T14:54:49Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+#ifdef USE_WEBSERVER
+void Max17043Show(void) {
+
+  WSContentSend_P(PSTR("Battery: %.1f V,  "), max17043->voltage/1000);


Use standard Tasmota GUI layout (Search code for examples)

Use standard Tasmota %1_f instead of not supported (because adds loads of unneeded code size) %.1f

arendst · 2023-05-29T14:55:23Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+void Max17043Show(void) {
+
+  WSContentSend_P(PSTR("Battery: %.1f V,  "), max17043->voltage/1000);
+  WSContentSend_P(PSTR("%.1f %%"), max17043->percentage);


Ditto. Search for HTTP_BATTERY for an example.

arendst · 2023-05-29T14:56:42Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+void Max17043Json(void) {
+
+  ResponseAppend_P(JSON_SNS_BGAUGE, mqttId, String(max17043->voltage/1000, 2), String(max17043->percentage, 1));
+}


Don't use String() as in takes way too much code (size). See other drivers how to use %2_f.

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

arendst · 2023-05-29T15:01:24Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+
+void Max17043Init(void) {
+
+  if (gauge.begin() != 0) {


Add I2cSetDevice() to test avialable I2C Address.

arendst · 2023-05-29T15:03:01Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+    AddLog(LOG_LEVEL_ERROR, PSTR("I2C: MAX17043 not found"));
+  } else {
+    max17043 = (MAX17043 *)calloc(1, sizeof(struct MAX17043));
+    AddLog(LOG_LEVEL_INFO, PSTR("I2C: MAX17043 initialized"));


Remove AddLog and add I2cSetActiveFound() claiming it's I2C address.

Your driver needs to integrate in Tasmota's I2C eco-system.

arendst · 2023-05-30T15:46:36Z

tasmota/tasmota_xx2c_global/xx2c_interface.ino

No need to change anything in this file. Remove from your PR

arendst · 2023-05-30T15:47:01Z

tasmota/tasmota_xx2c_global/xsns_interface.ino

Already merged. Remove from your PR.

ok, will be removed

arendst · 2023-06-03T12:31:28Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+
+#ifdef USE_WEBSERVER
+void Max17043Show(void) {
+  WSContentSend_PD(PSTR("{s}%s Voltage  {m}%1_f V  {e}"), SENSOR_NAME, &max17043->voltage);


Pls chg "Voltage" with defined D_VOLTAGE making it multi language.

Add "Capacity" as english word to all language files; translations will eventually be done by others.

arendst · 2023-06-03T12:32:42Z

tasmota/tasmota_xx2c_global/xsns_interface.ino

By removing this file the PR fails initial chks. Pls find another solution to fix PR and making it ready to merge.

modified: tasmota/language/bg_BG.h modified: tasmota/language/ca_AD.h modified: tasmota/language/cs_CZ.h modified: tasmota/language/de_DE.h modified: tasmota/language/el_GR.h modified: tasmota/language/en_GB.h modified: tasmota/language/es_ES.h modified: tasmota/language/fr_FR.h modified: tasmota/language/fy_NL.h modified: tasmota/language/he_HE.h modified: tasmota/language/hu_HU.h modified: tasmota/language/it_IT.h modified: tasmota/language/ko_KO.h modified: tasmota/language/nl_NL.h modified: tasmota/language/pl_PL.h modified: tasmota/language/pt_BR.h modified: tasmota/language/pt_PT.h modified: tasmota/language/ro_RO.h modified: tasmota/language/ru_RU.h modified: tasmota/language/sk_SK.h modified: tasmota/language/sv_SE.h modified: tasmota/language/tr_TR.h modified: tasmota/language/uk_UA.h modified: tasmota/language/vi_VN.h modified: tasmota/language/zh_CN.h modified: tasmota/language/zh_TW.h modified: tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

arendst · 2023-06-03T15:22:57Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+
+#ifdef USE_WEBSERVER
+void Max17043Show(void) {
+  WSContentSend_PD(PSTR("{s}%s D_VOLTAGE {m}%1_f V  {e}"), SENSOR_NAME, &max17043->voltage);


Getting close! Look how they did it here: "{s}%s " D_VOLTAGE "{m}%1_f " D_UNIT_VOLT "{e}". Notice the quotes.

arendst · 2023-06-03T15:24:02Z

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

+#ifdef USE_WEBSERVER
+void Max17043Show(void) {
+  WSContentSend_PD(PSTR("{s}%s D_VOLTAGE {m}%1_f V  {e}"), SENSOR_NAME, &max17043->voltage);
+  WSContentSend_PD(PSTR("{s}%s D_BATTERY_CAPACITY {m}%1_f %% {e}"), SENSOR_NAME, &max17043->percentage);


Ditto quotes.

Once changed pls test your code as this error should have been noticed by you too.

I think it worked, I normaly test before PR. Anyway, thanks for your patience with me!!

Jason2866 · 2023-06-03T15:24:55Z

.vscode/settings.json is still deleted with your PR, and you are doing changes in files not related with your PR. Please update your branch with latest development and remove the not needed changes in files.

Vincent1964 · 2023-06-03T15:44:11Z

To do that I have to revoke my PR, update and make a new PR, right?

Thanks for your patience!

Jason2866 · 2023-06-03T16:27:18Z

Probably easiest is to close this PR and open a new one.

Vincent1964 · 2023-06-03T17:26:33Z

For me yes but not for the Theo and other reviewers they then have to review all my code again.. I will try to remove the file from the PR

arendst · 2023-06-03T17:38:21Z

I agree with jason.

Take your time anyway as I won’t be able to merge the next fifteen days.

Vincent1964 · 2023-06-03T17:52:17Z

Okay Theo, relax

Vincent1964 added 8 commits May 21, 2023 16:03

Inital version, ready for debugging session.

e697b73

update settings

32d8d3a

Adding missing comma after function pointer

9efdf4b

update

0799cea

First working version, mqqt testing pending

3ea61b1

update defines in core

ad7e541

Finalizing, final touch. Ready for PR

2305d4e

Fixing typo

a4e6eb7

Vincent1964 commented May 29, 2023

View reviewed changes

arendst reviewed May 29, 2023

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

arendst reviewed May 29, 2023

View reviewed changes

tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino Show resolved Hide resolved

arendst reviewed May 29, 2023

View reviewed changes

Vincent1964 and others added 2 commits May 29, 2023 17:03

Delete settings.json

c39e8e6

solving issues

2e462c4

arendst reviewed May 30, 2023

View reviewed changes

tasmota/tasmota_xx2c_global/xx2c_interface.ino Outdated

Copy link

Owner

arendst May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change anything in this file. Remove from your PR

arendst reviewed May 30, 2023

View reviewed changes

Vincent1964 and others added 2 commits June 3, 2023 11:32

Fixed all comments from Arendst

4d407d2

Delete xsns_interface.ino

69fea36

arendst reviewed Jun 3, 2023

View reviewed changes

Vincent1964 marked this pull request as draft June 3, 2023 13:37

Vincent1964 added 2 commits June 3, 2023 17:04

adding i18n strings and undelete file

39684b8

arendst reviewed Jun 3, 2023

View reviewed changes

Vincent1964 added 2 commits June 3, 2023 17:29

modified: .gitignore

c69f01f

modified: .gitignore

4f0fcb8

Vincent1964 requested a review from arendst June 3, 2023 15:51

modified: tasmota/tasmota_xsns_sensor/xsns_109_max17043.ino

758cfe0

Vincent1964 deleted the branch arendst:development June 4, 2023 07:58

Vincent1964 closed this Jun 4, 2023

Vincent1964 deleted the development branch June 4, 2023 07:58

Vincent1964 restored the development branch June 4, 2023 08:02

sfromis mentioned this pull request Jun 4, 2023

MAX17043 sensor integration #18788

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for MAX17043 Lipo battery-gauge #18739

Adding support for MAX17043 Lipo battery-gauge #18739

Vincent1964 commented May 29, 2023 •

edited

Loading

Vincent1964 commented May 29, 2023

Vincent1964 left a comment

arendst May 29, 2023

Vincent1964 Jun 3, 2023

arendst May 29, 2023

Vincent1964 Jun 3, 2023

arendst May 29, 2023

Vincent1964 Jun 3, 2023

arendst May 29, 2023

Vincent1964 Jun 3, 2023

arendst May 29, 2023

Vincent1964 Jun 3, 2023

arendst May 30, 2023

arendst May 30, 2023

Vincent1964 Jun 3, 2023

arendst Jun 3, 2023

arendst Jun 3, 2023

arendst Jun 3, 2023

arendst Jun 3, 2023

Vincent1964 Jun 3, 2023

Jason2866 commented Jun 3, 2023

Vincent1964 commented Jun 3, 2023

Jason2866 commented Jun 3, 2023

Vincent1964 commented Jun 3, 2023

arendst commented Jun 3, 2023

Vincent1964 commented Jun 3, 2023

Adding support for MAX17043 Lipo battery-gauge #18739

Adding support for MAX17043 Lipo battery-gauge #18739

Conversation

Vincent1964 commented May 29, 2023 • edited Loading

Description:

Checklist:

Vincent1964 commented May 29, 2023

Vincent1964 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jason2866 commented Jun 3, 2023

Vincent1964 commented Jun 3, 2023

Jason2866 commented Jun 3, 2023

Vincent1964 commented Jun 3, 2023

arendst commented Jun 3, 2023

Vincent1964 commented Jun 3, 2023

Vincent1964 commented May 29, 2023 •

edited

Loading