Webcam mutex - fixes some AIThinker webcam issues #18652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to be able to (manually) run cmd I2CSCAN2.
…ltiple threads. Bugfix in Wc.up detect in WcInterruptControl?
Just added a deviation of your code so this is no lonfger needed.
Again, eneabled this in latest update to dev. No longer needed.
|
I've just made changes a bit different to what you suggested to the I2C init code. ALso enable I2C for the webcam. |
|
@arendst - hmm.. I don't see any mutex in new commits.... @Jason2866 fixed the Wc.up thing... and I see your I2C... do you want me to re-create the PR on top of the latest dev? br, |
|
Yes pls |
|
Replaced with a new one on top of modified dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes Discussion 18482
Investigation of webcam failures in AITHINKER esp32cam module indicate that the issue is likely multi-threading.
The modifications in this PR add a mutex to many webcam related functions in the webcam driver.
See discussion for the types of issues experienced.
NOTE: I have also enabled USE_I2C in webcam firmware - this is not necessary, but helps with understanding webcam hardware.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass