-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make IRHVAC send incremental changes. #18310
make IRHVAC send incremental changes. #18310
Conversation
I do not have an ESP32 IR Blaster to test. |
Thanks. I would rather have this in the standard build rather than a compile option. Can we think of a distinct command syntax for incremental? For ex adding a json field like "incremental":true? |
My original idea was to leverage
However, I have a lot of learning to do before I understand the code base enough to do that. |
Relying on Mem1 sounds overly complicated to me. Why not go back to your original idea, but as a runtime option, not a compile-time option? |
This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions. |
@TMaYaD Will you do the changes? |
Yes. I'm away on vacation right now. Will get back to it after 14th. Need to be home to test home automation ;) |
48686c7
to
47dbd17
Compare
This change will allow mqtt messages simpler by allowing something like `publish cmnd/ir-bridge/IRHVAC {"Power": "On"}`. The simpler format is required for working with mqtt clients like iotMQTTPanel or similar on android. Limitations: - Requires full message be sent at-least once. I work around this with a `system#boot` rule - Gets messy with multiple devices. I have only one AC per room, and this doesn't doesn't interfere with other IR devices. TODO: - [ ] Change the build flag `INCREMENTAL_IRAC`to a `SetOption` - [ ] Persist `irac_prev_state` across reboots. - [ ] Support multiple devices.
47dbd17
to
045399c
Compare
@Jason2866 Updated and tested on my IR blaster. It turned out to be simpler than I expected. |
This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
Nice improvement. Looking forward to testing this. Will make node-red flows simpler too. |
Description:
This change will allow mqtt messages simpler by allowing something like
publish cmnd/ir-bridge/IRHVAC {"Power": "On", "Incremental": true}
.The simpler format is required for working with mqtt clients like iotMQTTPanel or similar on android.
Limitations:
system#boot
ruleTODO:
irac_prev_state
across reboots.Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass