Align IR_TIME_AVOID_DUPLICATE across irremote_full.ino and irremote.ino and convert to #define #11421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce IR_TIME_AVOID_DUPLICATE to 50ms which was fixed in xdrv_05_irremote_full.ino in PR arendst#9969 but not here. Converted IR_TIME_AVOID_DUPLICATE from const to #define to enable override in the config override file.
Convert IR_TIME_AVOID_DUPLICATE from const to #define to enable override in the config override file.
ascillato
suggested changes
Mar 22, 2021
tasmota/xdrv_05_irremote.ino
Outdated
| const uint32_t IR_TIME_AVOID_DUPLICATE = 500; // Milliseconds | ||
|
|
||
| #ifndef IR_TIME_AVOID_DUPLICATE | ||
| #define IR_TIME_AVOID_DUPLICATE = 50 // Milliseconds |
There was a problem hiding this comment.
It is not needed the equal sign in a #define
Just delete the sign to pass the CI tests
ascillato
reviewed
Mar 22, 2021
tasmota/xdrv_05_irremote_full.ino
Outdated
| const uint32_t IR_TIME_AVOID_DUPLICATE = 50; // Milliseconds | ||
|
|
||
| #ifndef IR_TIME_AVOID_DUPLICATE | ||
| #define IR_TIME_AVOID_DUPLICATE = 50 // Milliseconds |
There was a problem hiding this comment.
It is not needed the equal sign in a #define
Just delete the sign to pass the CI tests
|
Good idea. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reduced IR_TIME_AVOID_DUPLICATE to 50ms in xdrv_05_irremote_full.ino, matching xdrv_05_irremote_full.ino which was fixed in PR #9969 but not here.
Converted IR_TIME_AVOID_DUPLICATE from const to #define to enable override in the config override file.
Related issue (if applicable): #9969
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass