Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DS18X20_MAX_SENSORS to be redefined #10178

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

barbudor
Copy link
Contributor

Description:

Following discussion with users on discord, this PR allows DS18X20_MAX_SENSORS to be redefined in user_config_override.h.
If merged I will document with warnings regarding MQTT buffer size and 1-wire length reliability.
Build as been tested with discord user earthquake on ESP8266 only

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works on Tasmota core ESP32 V.1.0.4.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 6aa26c6 into arendst:development Dec 19, 2020
@barbudor barbudor deleted the pr_number_ds18x20 branch December 19, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants