Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of LWT payload #9395

Closed
8 of 15 tasks
S474N opened this issue Sep 26, 2020 · 6 comments
Closed
8 of 15 tasks

Translation of LWT payload #9395

S474N opened this issue Sep 26, 2020 · 6 comments
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended

Comments

@S474N
Copy link
Contributor

S474N commented Sep 26, 2020

PROBLEM DESCRIPTION

Don't know, if this problem is in all languages, but in Czech version of Tasmota v8.5.0.1 is problem with translation of LWT payload.

It shows Aktivní/Neaktivní instead of Online/Offline.

This can make problems with another softwares/plugins, which expect standard english words.

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

  • Read the Contributing Guide and Policy and the Code of Conduct
  • Searched the problem in issues
  • Searched the problem in the docs
  • Searched the problem in the forum
  • Searched the problem in the chat
  • Device used (e.g., Sonoff Basic): Sonoff RFR3, Sonoff Mini
  • Tasmota binary firmware version number used: 8.5.0.1
    • Pre-compiled: precompiled CZECH version
    • Self-compiled
      • IDE / Compiler used: _____
  • Flashing tools used: _____
  • Provide the output of command: Backlog Template; Module; GPIO 255:
  Configuration output here:


  • If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:
  Rules output here:


  • Provide the output of this command: Status 0:
  STATUS 0 output here:


  • Provide the output of the Console log output when you experience your issue; if applicable:
    (Please use weblog 4 for more debug information)
  Console output here:


TO REPRODUCE

Check payload of /tele/device-id/LWT and power cycle

EXPECTED BEHAVIOUR

Use standard english strings, not translated.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

(Please, remember to close the issue when the problem has been addressed)

@Jason2866
Copy link
Collaborator

I do not see a translation for LWT payload in the cz laguage file. There is no other file for language specific translations. It looks like you have redefined "somewhere"

@S474N
Copy link
Contributor Author

S474N commented Sep 26, 2020

Please see link, which is mentioned.

I used standard tasmota-cz.bin, no changes. When I tested now with standard tasmota.bin, everything is OK.

@arendst
Copy link
Owner

arendst commented Sep 26, 2020

There are indeed translatioms in the cz.h language file.

A change is needed in the language file.

@arendst
Copy link
Owner

arendst commented Sep 26, 2020

Trouble is some other languages did indeed translate online/offline in their language....

What is common sense here....

S474N added a commit to S474N/Tasmota that referenced this issue Sep 26, 2020
Translate Neaktivní/Aktivní back to english original.

arendst#9395
@S474N S474N mentioned this issue Sep 26, 2020
6 tasks
@ascillato
Copy link
Contributor

ascillato commented Sep 26, 2020

May be we need to move the online key out of translation files due to it is not related to the webUI. What about move it to my_user_config.h? It makes more sense there?

@Jason2866
Copy link
Collaborator

Jason2866 commented Sep 26, 2020

I vote for moving out of language file too. I didnt even recognized that this was LWT...
Imho there is no need for this to be user configurable anywhere
I think the translations are done without knowing what the result will be

@ascillato2 ascillato2 added the enhancement Type - Enhancement that will be worked on label Sep 26, 2020
arendst added a commit that referenced this issue Sep 27, 2020
Make LWT state message user configurable (#9395)
@arendst arendst added the fixed Result - The work on the issue has ended label Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended
Projects
None yet
Development

No branches or pull requests

5 participants