-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wakeup light in 256 steps #9241
Comments
Please give more details about your setup. What kind of light are you using (pwm?) and did you enable gamma correction with |
I am using a 5050 SMD LED Strip in combination with a Magic Home controller. I don't use gamma correction, as LedTable == 0. |
However, I don't think it depends on my setup, but on the way the wakeup function is implemented. Right now the least bright is 1 percent (so 1/100) instead of the possible 1/256. The latter would result in a smoother wakeup pattern. |
Then I believe that you should enable Gamma Correction, otherwise the brightness goes very quickly to a high perceived value. |
I tried that function, but then my brightness of my led strip isn't lineair anymore and the initial brightness is still 1/100 instead of the possible 1/256. I think this issue is therefore a feature request, instead of a question. |
Hi, Have you tried |
Yes I did, but that made the smoothness of the LED strip's brightness worse. |
But as said here, it is not so much a problem, but more a suggestion to smoothen the wake up pattern. Because I use the LED strip with the wakeup function as a wakeup light divided over 20 minutes, the experience would be better if the brightness is incremented 1/256 every ~5 seconds, instead of an increase of 1/100 every 12 seconds. |
Ok. With that time frame you need a higher resolution. With smaller time frames the 100 steps are smooth enough. Changing to feature request. Thanks for explaining your use-case. |
@jesseruiter I completely agree with you. When you use Gamma Correction I don't have time in the short term to change this, but it shouldn't be a big change to the code, although we need to adjust the duration if it's 256 steps instead of 100. |
Thanks for your reaction! I look forward to the update sometime in the future. |
Oops, I observed a crash... Not ready |
Change ``WakeUp`` uses 256 steps instead of 100 (#9241)
Have you looked for this feature in other issues and in the docs?
yes
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
When the wakeup command is called, the light is still quite bright at the start and the fading isn't very smooth.
Describe the solution you'd like
A clear and concise description of what you want to happen.
When the wakeup command uses 256 (instead of 100) steps the fading will be smoother and I don't wake up directly when the value is 1%😁
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I can't come up with an alternative solution.
Additional context
Add any other context or screenshots about the feature request here.
Not needed.
(Please, remember to close the issue when the problem has been addressed)
The text was updated successfully, but these errors were encountered: