I2S bugfix: webradio crash with invalid url #21446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It has always be guaranteed to get a crash by providing an invalid url to the web radio command like:
i2swr i_am_not_a_valid_webradio_url
This did of course also include copy-paste-errors or former correct url names.
Besides every other occasional connection error did lead to a crash too.
Main problem was the audio library, which did no error checking.
Addditionally we check now for success in Tasmota as this is possible with this library change.
Removal of some unused code.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass