Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stay within Sentry quotas #20

Closed
brendanlong opened this issue Mar 18, 2019 · 1 comment
Closed

Stay within Sentry quotas #20

brendanlong opened this issue Mar 18, 2019 · 1 comment
Assignees
@brendanlong
Labels
bug Something isn't working enhancement New feature or request

Comments

@brendanlong
Copy link
Contributor

https://docs.sentry.io/accounts/quotas/#attributes-limits

We need to make sure events stay below 200 KB, and there's no point to sending attributes that are past the limits either since (best case), the server will remove them anyway.
@brendanlong brendanlong added bug Something isn't working enhancement New feature or request labels Mar 18, 2019
@brendanlong brendanlong self-assigned this Mar 18, 2019
brendanlong added a commit that referenced this issue Mar 18, 2019
@brendanlong
Cap max string length to 512 characters
eb01493 
This is the limit for most Sentry attributes (the server will discard
everything past this), and this should help us stay under the 200 KB
event size limit.

See #20
brendanlong added a commit that referenced this issue Mar 18, 2019
@brendanlong
Cap max string length to 512 characters
c83e347 
This is the limit for most Sentry attributes (the server will discard
everything past this), and this should help us stay under the 200 KB
event size limit.

See #20
@brendanlong brendanlong mentioned this issue Mar 18, 2019
Merged
brendanlong added a commit that referenced this issue Mar 19, 2019
@brendanlong
Cap max string length to 512 characters
9075d59 
This is the limit for most Sentry attributes (the server will discard
everything past this), and this should help us stay under the 200 KB
event size limit.

See #20
@brendanlong
Copy link
Contributor Author

I'm going to close this since after 9075d59 it's extremely unlikely that any event can be over 200 KB. If someone wants to make a pull request to catch 413 errors and strip out arrays that are too long I'd be happy to review it though.

@brendanlong brendanlong mentioned this issue Mar 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendanlong brendanlong

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brendanlong