Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cohttp 2.0.0 #16

Closed
gtrak opened this issue Feb 28, 2019 · 4 comments
Closed

Support cohttp 2.0.0 #16

gtrak opened this issue Feb 28, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@gtrak
Copy link

gtrak commented Feb 28, 2019

Currently it doesn't build with 2.0.0.

# File "src/dune", line 3, characters 33-45:
# 3 |   (libraries async_kernel atdgen cohttp.async core_kernel hex json-derivers uri uuidm re2 yojson)
#                                      ^^^^^^^^^^^^
@brendanlong
Copy link
Contributor

This should already be enforced by the .opam file: https://github.com/brendanlong/sentry-ocaml/blob/master/sentry.opam#L13

The tricky thing is that I don't think I can support both at the same time, since the library name changes and there are some minor changes to the API.

@brendanlong brendanlong added the enhancement New feature or request label Feb 28, 2019
@gtrak
Copy link
Author

gtrak commented Feb 28, 2019

Is it worth doing something like https://github.com/janestreet/ppx_optcomp

Does dune have a similar facility?

@brendanlong
Copy link
Contributor

There's probably some way we could this with Dune's "the dune file is an OCaml file" mode, but.. yikes.
If you think it's worth it, we could just switch to require cohttp>=2.0 though?

@gtrak
Copy link
Author

gtrak commented Feb 28, 2019

I'll think about it more, this is motivated by the TLS default override we made internally and the suspicion that a newer version of cohttp might be better, but I think I should spend more time looking into that.

brendanlong added a commit that referenced this issue Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants