Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MEIF with ROOT validation + CCC cut #1

Merged
merged 3 commits into from
Sep 17, 2018

Conversation

kmcdermo
Copy link

This PR includes a few fixes related to the CCCv2 branch.

  1. Fix MEIF with ROOT validation by allowing different threads to write to a single file.
  2. Fix segfault when trying to record last hit info if it happens to be == -9.
  3. Add some light documentation on indices (to be added later tonight -- don't merge just yet!).

Plots are here: https://kmcdermo.web.cern.ch/kmcdermo/mictrk/PR162_fixMEIFval_v2/
In addition, plots without MEIF for ROOT validation are included for comparison's sake (*_noMEIF). As expected, no difference is seen with and without MEIF.

    * deregister context of TFile to allow writing from multiple threads
    * make TFile's and TTree's std::unique_ptr
    * set directory of TTree to 0 when initialized, then set to file at the end
@kmcdermo
Copy link
Author

Hi Allie,

This can now be safely merged in your branch if you agree with the changes. MEIF validation should be stable now :).

@areinsvo areinsvo merged commit 9453a9e into areinsvo:CCCv2 Sep 17, 2018
@kmcdermo kmcdermo deleted the CCCv2_fixMEIFval_v2 branch May 21, 2019 18:10
areinsvo pushed a commit that referenced this pull request Jan 25, 2021
GenMul.pl - do not generate CUDA code unless explicitly requested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants