Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive filters #398

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Responsive filters #398

merged 4 commits into from
Oct 17, 2019

Conversation

antoinevinial
Copy link
Contributor

@antoinevinial antoinevinial commented Sep 25, 2019 •
edited
Loading

Bug :

When you add 5+ filters, they are all placed horizontally, forcing you to scroll, instead of creating new rows. Design is also broken on mobile.

Fix :

  • Remove scroll for Filters on desktop when there are multiple ones and create new rows if needed.
  • Fix mobile version : max-height was hard coded previously, now it's calculated dynamically to expand inner to the correct size.

Ticket :

Cloubhouse #175

Clubhouse #157 - Adjust filters layout on desktop when multiple ones …
f8a816b 
…+ fix mobile version to expand inner container as needed.
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ifox ifox changed the title Clubhouse #157 - Filters Responsive filters Sep 25, 2019
@ifox ifox merged commit b95820f into area17:1.2 Oct 17, 2019
@antoinevinial antoinevinial deleted the fix/filters-layout branch October 25, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoinevinial @CLAassistant @ifox