Add Control-Surface library #5444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ ERROR: Arduino Lint found errors with https://github.com/tttapa/Control-Surface: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @gwilherm After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Hello @gwilherm. Thanks for your interest in contributing to the Arduino Library Manager index.
I'm just adding a note here that you are working to fix the problem in the library repository that caused it to fail the submission checks:
per1234
added
the
status: waiting for information
per1234
reviewed
Dec 5, 2024
There was a problem hiding this comment.
In order to keep the repository tidy, I'm going to close this as I see there has not been any response from the library maintainer in the upstream issue (tttapa/Control-Surface#1095) and pull requests (tttapa/Control-Surface#1096) intended to bring the library into compliance.
@gwilherm once the library has been brought into compliance, please submit a new pull request.
I'll continue to monitor this thread, so feel free to comment if you have any questions or concerns.
Regards, Per
per1234
added
conclusion: invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.