Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL of "DirectCurrent Motor Module" #3706

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Update URL of "DirectCurrent Motor Module" #3706

merged 9 commits into from
Dec 6, 2023

Conversation

adrian2793
Copy link
Contributor

Name Request is still in progress.

I hope that's not a problem but I want to be sure you know that.

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi @adrian2793.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/arduino279/DC_Motor_Module:

Linting library in DC_Motor_Module
WARNING: library.properties name Engine Control contains spaces. Although supported, best practices is to not use       
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot requested a review from per1234 December 5, 2023 15:23
@adrian2793 adrian2793 changed the title Update URL of "DC_Motor_Module" Update URL of "DirectCurrent Motor Module" Dec 5, 2023
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Dec 5, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @adrian2793. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi @adrian2793.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

ERROR: Arduino Lint found errors with https://github.com/arduino279/DirectCurrent-Motor-Module:

Linting library in DirectCurrent-Motor-Module
WARNING: library.properties name value DirectCurrent_Motor_Module is longer than the recommended length of 16           
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
ERROR: Library name DirectCurrent_Motor_Module not found in the Library Manager index. Library names are not allowed to 
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties depends field item(s) DirectCurrent Motor Module not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP048)                                                                                               
WARNING: library.properties includes field item(s) Engine_Control.h not found in library.                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 4 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @adrian2793
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@adrian2793
Copy link
Contributor Author

@per1234 I changed the url again (last time i do this, i promise).. what now?

the new url is https://github.com/arduino279/DirectCurrent-Motor-Module

@github-actions github-actions bot requested a review from per1234 December 5, 2023 16:03
@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations and removed topic: modification Change existing list entry labels Dec 5, 2023
@per1234
Copy link
Contributor

per1234 commented Dec 5, 2023

what now?

Same as before. I have confirmed your request. Now the only thing remaining is for the Library Manager index maintainer to update the database accordingly.

They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@MatteoPologruto MatteoPologruto self-assigned this Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Hi @MatteoPologruto.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: modification Change existing list entry and removed topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Dec 6, 2023
@github-actions github-actions bot removed the request for review from per1234 December 6, 2023 16:58
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/12/06 16:46:30 Loaded 6429 libraries from DB
Removing Engine Control
Success!

Copy link
Contributor

github-actions bot commented Dec 6, 2023

ERROR: Arduino Lint found errors with https://github.com/arduino279/DirectCurrent-Motor-Module:

Linting library in DirectCurrent-Motor-Module
INFO: No header file found matching library name (DirectCurrent_Motor_Module.h). Best practices are for primary header  
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value DirectCurrent_Motor_Module is longer than the recommended length of 16           
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
ERROR: Library name DirectCurrent_Motor_Module not found in the Library Manager index. Library names are not allowed to 
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties depends field item(s) DirectCurrent Motor Module not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP048)                                                                                               
WARNING: library.properties includes field item(s) Engine_Control.h, REMgQ29tcG9uZW50.h, U2Vydm8gQ29tcG9uZW50.h not     
         found in library.                                                                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP052)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 4 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @MatteoPologruto
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 December 6, 2023 16:59
@MatteoPologruto MatteoPologruto merged commit f4a3866 into arduino:main Dec 6, 2023
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Dec 6, 2023
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants