Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

0.1 default color scheme sucks (near useless as everything is too dark) #310

Closed
paschlie opened this issue Aug 24, 2020 · 18 comments
Closed

0.1 default color scheme sucks (near useless as everything is too dark) #310

paschlie opened this issue Aug 24, 2020 · 18 comments
Labels
type: imperfection Something isn't working

Comments

@paschlie
Copy link

Open ide, and discover it's nearly illegible.
@paschlie paschlie added the type: imperfection Something isn't working label Aug 24, 2020
@kittaakos
Copy link
Contributor

@paschlie, can you please attach a screenshot to the issue?

@kittaakos
Copy link
Contributor

By default, the IDE comes with a (light) Arduino theme. Although we made a few UI changes, the theme should be the same. You can try to change it:

  • Open the Command Palette with Cltr/⌘+Shift+P,
  • Type: Color Theme,
  • Press enter,
  • Select another theme.

@paschlie
Copy link
Author

paschlie commented Aug 24, 2020 via email

@ubidefeo
Copy link

@paschlie
the IDE does not rely on the OS dark mode support but implements colour schemes.
The process described by @kittaakos (command palette and theme) should just work in the app and even preview the theme.
I haven't experienced the default to dark behaviour on Mojave or Catalina, but don't have a High Sierra machine to test on.
I'll try and setup a VM for testing and see if I can reproduce

@paschlie
Copy link
Author

paschlie commented Aug 26, 2020 via email •
edited
Loading

@ubidefeo
Copy link

@kittaakos
can you look into this?
any chance you have a High Sierra lying around?

@kittaakos
Copy link
Contributor

From the attached screenshots, I do not see how this issue is related to the theme, but the app should load.

@paschlie, what do you see in the console when you start the app from a terminal:

/Applications/Arduino\ Pro\ IDE.app/Contents/MacOS/Arduino\ Pro\ IDE

My output starts as:

root WARN please install @theia/[email protected] as a runtime dependency
root INFO Configuration directory URI: 'file:///Users/akos.kitta/.theia'
root INFO Configuring to accept webviews on '.+.webview..+' hostname.
root INFO Theia app listening on http://localhost:64533.
config INFO Started watching the Arduino CLI configuration: '/Users/akos.kitta/.arduinoProIDE/arduino-cli.yaml'.
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /Applications/Arduino Pro IDE.app/Contents/Resources/app/plugins/vscode-builtin-cpp
root INFO Resolved "vscode-builtin-cpp" to a VS Code extension "[email protected]" with engines: { vscode: '*' }
root INFO Deploying backend plugin "[email protected]" from "/Applications/Arduino Pro IDE.app/Contents/Resources/app/plugins/vscode-builtin-cpp/extension"
root INFO Deploy plugins list took: 34.8 ms
root WARN Backend ConfigServiceImpl.onStart is slow, took: 64.3 ms
daemon INFO Starting daemon from /Applications/Arduino Pro IDE.app/Contents/Resources/app/node_modules/arduino-ide-extension/build/arduino-cli...
daemon INFO Using config file: /Users/akos.kitta/.arduinoProIDE/arduino-cli.yaml
daemon INFO arduino-cli version 0.12.1
daemon INFO Setting up Prometheus telemetry on :9090/metrics
daemon INFO Starting daemon on TCP address 127.0.0.1:10000
daemon INFO Daemon is now listening on 127.0.0.1:10000...
daemon INFO Daemon is running.
root INFO Git askpass helper is listening on http://127.0.0.1:64538.
daemon INFO Checking signature [index: /Users/akos.kitta/Library/Arduino15/package_index.json, signaturefile: /Users/akos.kitta/Library/Arduino15/package_index.json.sig, trusted: true]
daemon INFO Checking signature [error: opening signature file: open /Users/akos.kitta/Library/Arduino15/package_esp32_index.json.sig: no such file or directory, index: /Users/akos.kitta/Library/Arduino15/package_esp32_index.json, signaturefile: /Users/akos.kitta/Library/Arduino15/package_esp32_index.json.sig]
daemon INFO Checking signature [error: opening signature file: open /Users/akos.kitta/Library/Arduino15/package_adafruit_index.json.sig: no such file or directory, index: /Users/akos.kitta/Library/Arduino15/package_adafruit_index.json, signaturefile: /Users/akos.kitta/Library/Arduino15/package_adafruit_index.json.sig]
daemon INFO Checking if CLI is Bundled into the IDE
daemon INFO Loading hardware from: /Users/akos.kitta/Library/Arduino15/packages
daemon INFO Loading package adafruit from: /Users/akos.kitta/Library/Arduino15/packages/adafruit/hardware
daemon INFO Loaded platform [platform: {ID:"adafruit:avr",Installed:"1.4.12",Latest:"1.4.13",Name:"Adafruit AVR Boards"}]
daemon INFO Loading package arduino from: /Users/akos.kitta/Library/Arduino15/packages/arduino/hardware
daemon INFO Loaded platform [platform: {ID:"arduino:avr",Installed:"1.8.3",Latest:"1.8.3",Name:"Arduino AVR Boards"}]
daemon INFO Loaded platform [platform: {ID:"arduino:mbed",Installed:"1.1.6",Latest:"1.1.6",Name:"Arduino nRF528x Boards (Mbed OS)"}]
daemon INFO Loaded platform [platform: {ID:"arduino:megaavr",Installed:"1.8.6",Latest:"1.8.6",Name:"Arduino megaAVR Boards"}]
daemon INFO Loaded platform [platform: {ID:"arduino:samd",Installed:"1.8.8",Latest:"1.8.8",Name:"Arduino SAMD Boards (32-bits ARM Cortex-M0+)"}]
daemon INFO Checking existence of 'tools' path: /Users/akos.kitta/Library/Arduino15/packages/arduino/tools
daemon INFO Loading tools from dir: /Users/akos.kitta/Library/Arduino15/packages/arduino/tools

@paschlie
Copy link
Author

paschlie commented Aug 27, 2020 via email

@kittaakos
Copy link
Contributor

kittaakos commented Aug 27, 2020 •
edited
Loading

config ERROR Error occurred when loading CLI config from /Users/paul/.arduinoProIDE/arduino-cli.yaml. YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key at line 4, column 77: ... ndex/package_adafruit_index.json ^ at generateError (/Applications/Arduino Pro IDE.app/Contents/Resources/app/node_modules/js-yaml/lib/js-yaml/loader.js:167:10) at throwError (/Applications/Arduino Pro IDE.app/Contents/Resources/app/node_modules/js-yaml/lib/js-yaml/loader.js:173:9) at readBlockMapping (/Applications/Arduino Pro IDE.app/Contents/Resources/app/node_modules/js-yaml/lib/js-yaml/loader.js:1073:9)

This is very helpful. The app could not start, because the CLI configuration is invalid. Of course, this is a bug and the IDE must be smarter to handle invalid configuration files gracefully. The config is at ~/.arduinoProIDE/arduino-cli.yaml.

Can you please share its content with us. Mine looks like this:

cat ~/.arduinoProIDE/arduino-cli.yaml 
board_manager:
  additional_urls: [
    'https://dl.espressif.com/dl/package_esp32_index.json',
    'https://adafruit.github.io/arduino-board-index/package_adafruit_index.json'
  ]
daemon:
  port: "10000"
directories:
  data: /Users/akos.kitta/Library/Arduino15
  downloads: /Users/akos.kitta/Library/Arduino15/staging
  user: /Users/akos.kitta/Documents/Arduino
logging:
  file: ""
  format: text
  level: info
telemetry:
  addr: :9090
  enabled: true

There are two ways to solve this issue:

  • you can try to correct it manually,
  • or delete the file and the IDE will recreate it with the defaults.

I can see another problem from the logs:

daemon INFO Setting up Prometheus telemetry on :9090/metrics
daemon INFO Starting daemon on TCP address 127.0.0.1:50051
daemon ERROR listen tcp :9090: bind: address already in use

There is a telemetry port that is used by some other application, so the CLI just crashes at runtime. Can you check what's running on port 9090 on your mac?

Thank you for your persistence in figuring out the root cause of the defect. 👍

@paschlie
Copy link
Author

paschlie commented Aug 27, 2020 via email

@kittaakos
Copy link
Contributor

Mine was:

Thanks! That's incorrect YAML:

board_manager:
  additional_urls:
   - https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json
   - https://adafruit.github.io/arduino-board-index/package_adafruit_index.json

daemon:
  port: "50051"
directories:
  data: /Users/paul/Library/Arduino15
  downloads: /Users/paul/Library/Arduino15/staging
  user: /Users/paul/Documents/Arduino
logging:
  file: ""
  format: text
  level: info
telemetry:
  addr: :9090
  enabled: true

or

board_manager:
  additional_urls: [
   'https://files.seeedstudio.com/arduino/package_seeeduino_boards_index.json',
   'https://adafruit.github.io/arduino-board-index/package_adafruit_index.json'
   ]

daemon:
  port: "50051"
directories:
  data: /Users/paul/Library/Arduino15
  downloads: /Users/paul/Library/Arduino15/staging
  user: /Users/paul/Documents/Arduino
logging:
  file: ""
  format: text
  level: info
telemetry:
  addr: :9090
  enabled: true

are the correct format.

@paschlie
Copy link
Author

paschlie commented Aug 27, 2020 via email

@kittaakos
Copy link
Contributor

How should additional board managers be added within the IDE?

Check this thread: #245 (comment)

It describes how to add additional, 3rd party URLs.

@paschlie
Copy link
Author

paschlie commented Aug 27, 2020 via email

@kittaakos
Copy link
Contributor

with the exception of anything you may have discovered during the dialog which should be further refined

Sure, I will create follow-ups regarding the CLI config issue.

I am so happy we managed to figure out the what was causig the problem. Thank you for giving us some time to find the solution.

(I am going to close the task once the follow-up GH issue exists.)

@paschlie
Copy link
Author

paschlie commented Aug 27, 2020 via email

@kittaakos
Copy link
Contributor

As a closing thought, it might be nicer if third-party board support urls could be added within the ide’s board selection pane

Sure, I already created an feature request in the upstream framework: eclipse-theia/theia#8081

Also, please note, we used to have proper validation in the YAML editor: https://user-images.githubusercontent.com/1405703/75560969-7a0b6880-5a46-11ea-935c-2adba1b28d8a.gif

But we had to remove because of this issue on Windows: https://github.com/arduino/arduino-pro-ide/issues/293#issuecomment-667139709

@kittaakos
Copy link
Contributor

Follow-up: https://github.com/arduino/arduino-pro-ide/issues/322

@kittaakos kittaakos mentioned this issue Aug 31, 2020
Closed
@kittaakos kittaakos mentioned this issue Mar 1, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: imperfection Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittaakos @ubidefeo @paschlie