Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling pagination in getting the sketches #875

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

ulemons
Copy link
Contributor

@ulemons ulemons commented Feb 28, 2022

Motivation

The remote sketchbook is limited to 20 sketches. It is needed to enable the pagination in order to get all the remote sketches.

Change Description

Instead of doing just one call to retrive all the sketches, the component will keep calling the api with a window of 50 sketches per call. Untill it will get all of them.

Reviewer checklist

  • PR address a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one).
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Umberto Sgueglia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 linked an issue Feb 28, 2022 that may be closed by this pull request
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 28, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to reproduce #809 with the latest nightly build. With the build from this PR the remote sketchbook shows the >100 sketches from my Arduino Create sketchbook.

Thanks @ulemons!

@fstasi
Copy link
Contributor

fstasi commented Mar 1, 2022

@ulemons can you please add a description to this pr?

take a look at this PR if you need some inspiration: #872

Thanks,
Francesco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote sketchbook is limited to 20 sketches
4 participants