Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray brace from compilation error output #751

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Remove stray brace from compilation error output #751

merged 1 commit into from
Jan 17, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jan 15, 2022

An extra brace was inadvertently introduced into a template literal used to format output text in the event of an error
during compilation. This caused the text to end in a pointless }

For example, compiling this sketch:

#error
void setup() {}
void loop() {}

Previously produced this output:

C:\Users\per\AppData\Local\Temp\.arduinoIDE-unsaved2022014-9692-1u5eon9.v425\sketch_jan14a\sketch_jan14a.ino:1:2: error: #error 
 #error
  ^~~~~
Compilation error: exit status 1}

After this change, the output text is as expected:

C:\Users\per\AppData\Local\Temp\.arduinoIDE-unsaved2022014-9692-1u5eon9.v425\sketch_jan14a\sketch_jan14a.ino:1:2: error: #error 
 #error
  ^~~~~
Compilation error: exit status 1

An extra brace was inadvertently introduced into a template literal used to format output text in the event of an error
during compilation. This caused the text to end in a pointless `}`

For example:

```
Compilation error: exit status 1}
```

After this change, the output text is as expected:

```
Compilation error: exit status 1
```
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 15, 2022
@per1234 per1234 self-assigned this Jan 15, 2022
@per1234 per1234 merged commit 66fc27e into arduino:main Jan 17, 2022
@per1234 per1234 deleted the stray-brace branch January 17, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants