Remove gRPC error code from error notifications #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
type: enhancement
silvanocerza
requested review from
fstasi,
ubidefeo,
AlbyIanna,
per1234 and
91volt
fstasi
approved these changes
Dec 3, 2021
| @@ -227,11 +229,12 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService { | |||
| result.on('end', () => resolve()); | |||
| }); | |||
| } catch (e) { | |||
| const errorMessage = `Error while burning the bootloader: ${e.details}`; | |||
There was a problem hiding this comment.
I know errors are not localized (yet)... but they should..
Maybe we can start adopting i18n for new errors
There was a problem hiding this comment.
@silvanocerza btw the PR is good. 🪄
silvanocerza
force-pushed
the
scerza/better-errors-notification
branch
from
372a820 to
55da22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation error before:
Upload error before:
Compilation error after:
Upload error after:
Fixes #151.