-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upload and serial #661
Conversation
79eb9ff
to
7d10e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that this change makes #613 persist even after one of the windows was closed:
Note that the other window is still displaying the mixture of the output from both boards. The same applies to Serial Plotter. Prior to the changes made in this PR, the mixed serial output behavior introduced by #597 ceased once one port was closed, but after this change the mixed output state persists and attempts to upload to board 2 fail with an "Access is denied" error. |
2bca1e1
to
9d2d8ee
Compare
9d2d8ee
to
d2624b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐕
Why
This PR fixes #615 by refactoring part of the logic involved when creating and managing the serial connection.
How
How it worked before
How it works now
We completely re-designed how the connection mechanism works, moving the vast majority of the business logic from the FE to the BE