Rework listing of discovered ports #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/board-discovery-refactor
branch
from
479b765
to
fd7d434
Compare
silvanocerza
force-pushed
the
scerza/board-discovery-refactor
branch
from
328c211
to
4e7215d
Compare
silvanocerza
requested review from
fstasi,
AlbyIanna,
91volt,
giannicolab,
per1234 and
ubidefeo
silvanocerza
force-pushed
the
scerza/board-discovery-refactor
branch
2 times, most recently
from
c0bf995
to
e2bbcb1
Compare
silvanocerza
force-pushed
the
scerza/board-discovery-refactor
branch
from
78ed015
to
fad5e5e
Compare
91volt
approved these changes
Nov 23, 2021
fstasi
approved these changes
Nov 23, 2021
fstasi
force-pushed
the
scerza/board-discovery-refactor
branch
from
fad5e5e
to
a846184
Compare
Now ports are shown in this order: 1. Serial with recognized boards 2. Serial with unrecognized boards 3. Network with recognized boards 4. Network with unrecognized boards 5. Other protocols with recognized boards 6. Other protocols with unrecognized boards
Ordering is now: 1. Serial with recognized boards 2. Serial with guessed boards 3. Serial with incomplete boards 4. Network with recognized boards 5. Other protocols with recognized boards
…nd change its style
AlbyIanna
force-pushed
the
scerza/board-discovery-refactor
branch
from
5ff1e33
to
4042f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things:
Ports in Tools > Ports menu are now sorted like this:
All recognized boards name are shown in parentheses after the port name.
In the screenshot below you see two boards for each port because I have development cores in my Sketchbook folder so two boards with different FQBN but identical name are found.
Board and ports combination in Board Selector dropdown are now sorted like this:
Previously selecting an item would change the ordering by putting it on top, now it doesn't anymore.
Network ports were never shown previously, only serial ports where.
Ports in Select Board dialog are now sorted like this:
If the Show all ports box is checked they're sorted like this:
Note: For testing I've used the refactored version of the
mdns-discoverythat is still not released. So you'll have a different experience than me with network ports, you'll see fewer, they'll never disappear after being discovered and similar issues.