Fix cortex-debug related debugging issue #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
force-pushed
the
msujew/fix-debugging-issue
branch
from
117f640
to
93c5964
Compare
msujew
force-pushed
the
msujew/fix-debugging-issue
branch
from
93c5964
to
e24c011
Compare
per1234
added
topic: code
fstasi
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527
As we can assume that the backend session is indeed destroyed (gdb session), we can simply destroy the frontend session without worrying about a dangling debug session somewhere.
Be aware, that this is connected to an upstream Theia issue: eclipse-theia/theia#10164
How to test