Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local sketchbook tree #446

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Improve local sketchbook tree #446

merged 1 commit into from
Jul 21, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Jul 9, 2021 •
edited
Loading

Why

Need to improve the user experience when working on local files.

  • As a user, I expect the current file I'm working on in the Editor to be highlighted in the sketchbook explorer
  • As a user, I expect the local sketchbook explorer to reflect changes happening in the file system. Eg: I expect to immediately see freshly added/renamed/deleted files in the sketchbook explorer tree

How

  • Refactored the sketchbook tree to use a single root node which contains a child for every directory in the Arduino user directory
  • Re-create the node tree when changes in either Monaco/FileSystem happens. This let us update the sketchbook treen when files are added-removed to directories as well as selecting the current focused file in the Monaco editor
  • Removed useless re-renders of the sketchbook explorer during IDE startup

Notes

Jira Tasks:

@fstasi fstasi requested a review from AlbyIanna July 9, 2021 07:45
@fstasi fstasi force-pushed the improve-sketchbook-tree branch 2 times, most recently from af726db to 527a34d Compare July 9, 2021 12:53
@fstasi fstasi marked this pull request as ready for review July 12, 2021 12:50
@fstasi fstasi force-pushed the improve-sketchbook-tree branch 2 times, most recently from 072c656 to 84d8232 Compare July 12, 2021 12:55
@fstasi fstasi merged commit 4da5d57 into main Jul 21, 2021
@fstasi fstasi deleted the improve-sketchbook-tree branch July 21, 2021 13:49
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fstasi @AlbyIanna @per1234