Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Arduino CLI 0.36.0-rc.1 APIs #2334

Merged
merged 4 commits into from
Feb 20, 2024
Merged

feat: use Arduino CLI 0.36.0-rc.1 APIs #2334

merged 4 commits into from
Feb 20, 2024

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jan 17, 2024 •
edited
Loading

Motivation

Use Arduino CLI 0.36.0-rc.1 APIs in IDE2.

Change description

Other information

Closes #2184
Closes #1783
Closes #1199
Closes #1588

#1588 in action:

gh_1588.mp4

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: CLI Related to Arduino CLI labels Jan 17, 2024
@kittaakos kittaakos mentioned this pull request Jan 18, 2024
Closed
4 tasks
@kittaakos kittaakos added the type: imperfection Perceived defect in any part of project label Jan 18, 2024
@kittaakos kittaakos mentioned this pull request Jan 26, 2024
Closed
4 tasks
@kittaakos kittaakos force-pushed the use-cli-0.36.0 branch 2 times, most recently from a4a64eb to 7924adf Compare February 8, 2024 15:30
This was referenced Feb 8, 2024
Closed
Closed
@kittaakos kittaakos force-pushed the use-cli-0.36.0 branch 3 times, most recently from 60b3120 to 3093a85 Compare February 9, 2024 12:04
@kittaakos kittaakos marked this pull request as ready for review February 9, 2024 16:38
davegarthsimpson
davegarthsimpson approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a handful of checks on the build from the UI. Didn't see any issues.

I've checked the changed files, didn't see anything problematic code-wise.

Great work!

Akos Kitta added 4 commits February 20, 2024 13:09
feat: use Arduino CLI 0.36.0-rc.1 APIs
405b4fe 
Signed-off-by: Akos Kitta <[email protected]>
fix: can unset network#proxy in the CLI config
c18f23e 
An empty object (`{}`) must be used to correctly unset the CLI config
value to its default.

Closes #2184

Signed-off-by: Akos Kitta <[email protected]>
feat: cancelable verify+upload
cef1ccb 
Closes #1199

Signed-off-by: Akos Kitta <[email protected]>
fix: invalid custom board option handling in FQBN
039c147 
Closes #1588

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos merged commit a088ba9 into main Feb 20, 2024
25 checks passed
@kittaakos kittaakos deleted the use-cli-0.36.0 branch February 20, 2024 12:38
@per1234 per1234 mentioned this pull request Feb 26, 2024
Open
3 tasks
@per1234 per1234 mentioned this pull request Aug 22, 2024
Closed
3 tasks
@per1234 per1234 mentioned this pull request Sep 26, 2024
Closed
3 tasks
@per1234 per1234 mentioned this pull request Sep 26, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

@giacomocusinato giacomocusinato Awaiting requested review from giacomocusinato

Assignees
No one assigned
Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @davegarthsimpson