-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: forward backend logging to electron #2236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Sep 22, 2023
kittaakos
force-pushed
the
electron-main-logger
branch
from
September 22, 2023 08:26
77dec97
to
bb4a9c0
Compare
kittaakos
commented
Sep 22, 2023
arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Sep 22, 2023
arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
Show resolved
Hide resolved
kittaakos
force-pushed
the
electron-main-logger
branch
from
September 22, 2023 09:42
bb4a9c0
to
b7acd65
Compare
Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
electron-main-logger
branch
from
September 22, 2023 14:29
b7acd65
to
79c7284
Compare
kittaakos
changed the title
fix: forward log from electron to backend process
fix: forward backend logging to electron
Sep 22, 2023
per1234
requested changes
Sep 25, 2023
arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Akos Kitta <[email protected]>
per1234
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this causes the previously missing content to be written to the log file.
Thanks Akos!
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Problem: When IDE2 runs in production mode (the app is bundled up), it logs into a file. When IDE2 starts, multiple processes start under the hood. The process hierarchy is like this electron main > backend main >> plugins_fsWatcher_and_other_subProcesses. IDE2 logs only in the backend main process and its child processes. The electron main process logging is missing from the generated single log file.
Since the electron main logging is missing, it very often happens that IDE2 does not even start on users' env (due to file permission, IPv6 vs. IPv4 issue, etc.), and the cause (error) is missing from the logs.
This PR enables logging in the electorn main module, and the backend main with all its children will forward the log to the electron main via IPC. So it's in a centralized place and can be written into a file in production mode.
Steps to verify:
~/Library/Logs/Arduino IDE
),You must see such entries in the generated log files:
The order of the log entries in the generated file and from the terminal is the same.
Change description
Other information
Reviewer checklist