fix: the focus in the sketchbook widget #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
topic: code
per1234
requested changes
Mar 24, 2023
There was a problem hiding this comment.
It seems to have a harmful effect on accessibility.
Here you can see the IDE used with the popular NVDA screen reader (with the highlighting feature enabled to make it easy to see the reader focus in the screencast).
When using the IDE build from main, the sketchbook view is automatically focused for easily keyboard navigation:
It no longer takes focus when I use the build from this PR:
Ref: #1720 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
fix-sketchbook-widget-focus
branch
from
6d5dec8
to
cd85e32
Compare
Great review. I pushed a patch. Now, the focus should be on the button. If IDE2 prefers to stick to the 2.0.4 behavior, I am OK with it, let's close this PR, and we can fix the styling issue differently. focus_on_button.mp4 |
per1234
approved these changes
Mar 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in #1720, the focus border looks odd when activating the Sketchbook widget. This PR fixes it.
Before the fix (with
2.0.4):sketchbook_focus_204.mp4
After the fix:
sketchbook_focus_fix.mp4
Change description
Other information
Ref: #1720
Reviewer checklist