Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: start the LS with the board specific settings #1812

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix: start the LS with the board specific settings #1812

merged 1 commit into from
Jan 16, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jan 10, 2023 •
edited
Loading

Motivation

The Arduino Language features must incorporate the settings of the selected board.

Change description

From now on, the IDE2 starts the LS with the FQBN decorated with the settings. Open the DevTools and check the console if you're interested:

INFO Starting language server: teensy:avr:teensy41:usb=serial,speed=600,opt=o2std,keys=en-us

Also, from now on, the LS restarts when the user changes the board settings of the currently running LS.

Steps to verify:

In action:

1029.mp4

Other information

Closes #1029

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: language server Related to the Arduino Language Server labels Jan 10, 2023
AlbyIanna
AlbyIanna approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected for me. I just left a remark about a little typo in a comment

arduino-ide-extension/src/common/protocol/boards-service.ts Outdated Show resolved Hide resolved
fix: start the LS with the board specific settings
dd0b127 
restart the LS when board settings of the running LS has changed

Closes #1029

Signed-off-by: Akos Kitta <[email protected]>
per1234
per1234 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 40e7979 into main Jan 16, 2023
@kittaakos kittaakos deleted the #1029 branch January 16, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language Server (autocomplete) not using menu settings
3 participants
@kittaakos @AlbyIanna @per1234