Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use a local npm registry for app packaging #1757

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Dec 9, 2022

Motivation

  • Speed up the build by eliminating the copy phase (this change does not affect the app signing or the ZIP structure modification part, solely the build by saving time with a filesystem copy and a yarn install),
  • Simplify the packager by getting rid of the file: local path (the arduino-ide-extension npm package can be picked up from the private npm registry),
  • Update to [email protected] (this change should help IDE2 to keep up with Theia and eliminates various dependabot alerts),
  • Fix incorrect electron imports in the code (electron must not be imported directly but from @theia/core/electron-shared),
  • Remove unnecessary electron-builder resolutions for yarn (no need for it with the @theia/*@1.3.1 version), and
  • Lint the app packager code (it belongs to the IDE2's code base).

Change description

Other information

  • (this change does not affect the app signing or the ZIP structure modification part, solely the build),

Package time on ubuntu from

  • the main is 9m 13s,
  • this PR is 8m 37s.

This PR should not change the IDE2 behavior.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 9, 2022
@kittaakos kittaakos changed the title build: use a private npm registry for the app packaging build: use a local npm registry for app packaging Dec 9, 2022
@kittaakos
Copy link
Contributor Author

Other information

  • (this change does not affect the app signing or the ZIP structure modification part, solely the build),

Package time on ubuntu from

  • the main is 9m 13s,
  • this PR is 8m 37s.

To be fair, the build times cannot be compared because they contain the npm, Open VSX, S3, and other remote requests and the app signing time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants