Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting primary tab has no effect #649

Closed
per1234 opened this issue Dec 1, 2021 · 1 comment · Fixed by #1833
Closed

Deleting primary tab has no effect #649

per1234 opened this issue Dec 1, 2021 · 1 comment · Fixed by #1833
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 1, 2021 •
edited
Loading

Describe the problem

Sketch files can be deleted by selecting "Delete" from editor toolbar context menu.

🐛 The "Delete" menu option is enabled when the primary tab is selected, and a confirmation dialog indicates it will delete the sketch, but nothing happens.

To reproduce

  1. Select File > New from the Arduino IDE menus.
  2. Save the sketch to somewhere convenient.
  3. Select the leftmost tab of the sketch.
  4. Click the ●●● icon on the right side of the editor toolbar.
  5. Select "Delete" from the menu.
    A "Do you want to delete the current sketch?" dialog will appear.
  6. Click the OK button.

🐛 The sketch remains open in Arduino IDE.

🐛 If you check the location of the sketch on your drive, you will see that it is still present.

Expected behavior

If sketch deletion is offered, it should work.

Arduino IDE version

Original report

2.0.0-rc1-snapshot.f0d9894

Last verified with

692f29f

Operating system

  • Windows
  • macOS

Operating system version

  • Windows 10
  • Windows 11
  • macOS 12.5.1

Additional context

Arduino IDE 1.x has the same behavior of deleting the sketch when the primary tab is deleted via the tab management menu, except it works in Arduino IDE 1.x.

Additional reports
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 1, 2021
@mklemarczyk

This comment was marked as off-topic.

Sign in to view
@per1234 per1234 mentioned this issue Nov 19, 2022
Open
3 tasks
@per1234 per1234 mentioned this issue Jan 30, 2023
Closed
3 tasks
This was referenced Jan 30, 2023
Closed
Merged
@kittaakos kittaakos assigned kittaakos and unassigned fstasi Jan 31, 2023
kittaakos pushed a commit that referenced this issue Feb 13, 2023
feat: rename, deletion, and validation support
adf3dcf 
Closes #1599
Closes #1825
Closes #649
Closes #1847
Closes #1882

Co-authored-by: Akos Kitta <[email protected]>
Co-authored-by: per1234 <[email protected]>

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename, deletion, and validation support arduino/arduino-ide
4 participants
@kittaakos @fstasi @mklemarczyk @per1234