Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"File > Preferences" disabled if dialog used soon after IDE startup #1735

Closed
3 tasks done
per1234 opened this issue Dec 4, 2022 · 3 comments · Fixed by #1744
Closed
3 tasks done

"File > Preferences" disabled if dialog used soon after IDE startup #1735

per1234 opened this issue Dec 4, 2022 · 3 comments · Fixed by #1744
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 4, 2022 •
edited
Loading

Describe the problem

If the "Preferences" dialog is opened soon after Arduino IDE is started, after closing the menu the File > Preferences menu item is disabled.

To reproduce

  1. Start Arduino IDE.
  2. Watch the Arduino IDE window. As soon as the menu bar appears, select File > Preferences.
  3. The "Preferences" dialog may be empty. Wait for it to populate.
  4. Click the "CANCEL" button.
  5. Open the File menu.

🐛 The File > Preferences menu item is disabled:

image

Expected behavior

File > Preferences menu item is only disabled if there is a specific reason the preferences dialog should not be accessible to the user (The only reason I can think of is if the dialog is already open, but that should be handled by making the dialog modal).

Arduino IDE version

5695fd8

Operating system

Windows

Operating system version

10

Additional context

I bisected the introduction of the bug to 7d6a2d5 / #1581 (does not occur when using the build for 6984c52).

Similar to #1722 (note they were bisected to the same commit).

The fault does not occur if the IDE startup process is allowed to finish completely (as indicated by the disappearance of the busy spinner next to the mouse pointer).

The menu item is enabled in new Arduino IDE windows that are opened when the menu item is in the disabled state in the parent window.

Even when the menu item is in the disabled state, I can still open the "Preferences" dialog using the keyboard shortcut (Ctrl+,), or "Arduino: Open Preferences" command palette command.

I have experienced a similar fault with Tools > WiFi101 / WiFiNINA Firmware Updater, but have not found a way to reproduce it.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 4, 2022
@kittaakos kittaakos self-assigned this Dec 5, 2022
kittaakos pushed a commit that referenced this issue Dec 6, 2022
fix: Preferences menu enablement defect
47644ab 
Manually update the menus when executing the command.

Also disabled the menu when the settings dialog is opened.

closes #1735

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor

kittaakos commented Dec 6, 2022 •
edited
Loading

2. select File > Preferences.

Note that it can be reproduced with Ctrl/Cmd+,.

(The only reason I can think of is if the dialog is already open, but that should be handled by making the dialog modal).

I added this to the PR.

1735.mp4

@kittaakos kittaakos mentioned this issue Dec 6, 2022
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Dec 7, 2022
@kittaakos
fix: Preferences menu enablement defect
ed8ed15 
Manually update the menus when executing the command.

Also disabled the menu when the settings dialog is opened.

closes #1735

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Dec 7, 2022
@kittaakos kittaakos mentioned this issue Dec 8, 2022
Merged
4 tasks
@sunzhongmeng
Copy link

I have the same problem.there is nothing in the Preferences dialog.
the OS is windows 10 Home (21H2)
image

@per1234
Copy link
Contributor Author

per1234 commented Dec 28, 2022

Hi @sunzhongmeng. That is a completely different fault. This issue is about the File > Preferences menu item being disabled. Your problem is the "Preferences" dialog being empty.

I saw your report about this on the Arduino Forum and am intending to investigate it:

https://forum.arduino.cc/t/arduino-ide-2-0-3-is-now-available/1061763/12

We can start over there and then create a dedicated bug report here if appropriate once we know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Preferences menu enablement defect arduino/arduino-ide
3 participants
@kittaakos @sunzhongmeng @per1234