Allow naming sketches like "RCS" and "CVS" #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2020 13:46
cmaglie
added a commit
to arduino/arduino-builder
that referenced
this pull request
Jan 23, 2020
Fix library priority selection - arduino/arduino-cli#565 Load contents of source files only when needed - arduino/arduino-cli#559 Allow naming sketches like "RCS" and "CVS" - arduino/arduino-cli#537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522
The filter we use to ignore files contained in version control systems' cache was applied to the sketch folder itself, thus preventing a sketch to be named like
RCS.This PR increases resiliency by avoiding panics if a sketch name couldn't be found and applies blacklist filters only to folders contained in the sketch, i.e. excluding the root folder.