gRPC: if an Upload
request is canceled, immediately terminate the upload tool process.
#2726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
If an
Upload
gRPC request is canceled, the underlying upload tool is terminated immediately.In particular, this affects the Arduino IDE "cancel" button, because the IDE can only cancel the
Upload
gRPC request and has no control over the underlying upload tool.What is the current behavior?
If an
Upload
gRPC request is canceled, the underlying upload tool is NOT terminated, and it may take a very long time to timeout and close itself.What is the new behavior?
The upload tool is terminated immediately.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Related to: