-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative paths if commandline is too long #249
Conversation
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
@matthijskooijman I'm only concerned about these metrics , otherwise I'd merge it immediately. Do you have any idea about the regression (if it exists)? |
I attempted a compile of Marlin using 1.8.5 and it failed. I loaded the 249 build of arduino-builder.exe and received same error as standard arduino 1.8.5:
Note: this error is different error than the original error verbage, first reported here: olikraus/U8glib_Arduino#9 I attempted to re-download the previous debug build of arduino-builder.exe from here: arduino/Arduino#6751 (comment) but received the following anti-virus warning and auto-deletion: So unable to determine if new error verbage is due to path-length exhaustion or new error due to 1.8.5 (I had previously tested the first debug build on 1.8.4 and it had resolved). Will report back if I get more info. |
Mmmmh, it's very unlikely that the debug build contains a virus, it's probably a false positive but I'll investigate. About the error, it looks indeed unrelated with the previous report. My 2 cents, it could be an "aggressive" antivirus related problem; try pausing it while you compile, if it works you should whitelist avr-gcc. |
What are the odds ? ;) No, Arduino IDE only reports the first 32000 chars in it's output window. If you review the end of the command you'll see it is incomplete, ending in the "
and identical to that I reported earlier in this post which did have the issue but was resolved by your earlier debug build: arduino/Arduino#6751 (comment) I will scan the old binary on a mac then test again on a Windows system (my previous test was on a throw-away VM that had no AV software, which I do not have access to now). |
old debug also failed with same error @bobc had this to say about the new error behavior:
|
Ok for lowering the threshold, I'll fix the PR tomorrow |
Continued at #250 |
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Fixes arduino/Arduino#6751
The non mangled commandline gets printed when verbose is on (see here) , even thought it's been modified to become relative. Need to discuss if some warning needs to be issued to communicate that the commandline is too long and thus executing it as-is would fail.