Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions actions used in sketch compilation CI workflows #98

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Update GitHub Actions actions used in sketch compilation CI workflows #98

merged 2 commits into from
Apr 20, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Apr 2, 2021

The "smoke test" sketch compilation and reporting actions have been moved to dedicated repositories. The actions hosted
at the old arduino/actions/libraries/* location will no longer be maintained.

Since the time the actions were migrated to the dedicated repositories, a breaking change was made to the default value of the sketches-report-path input, which required a change to the values of the name and path inputs of the actions/upload-artifact action.

Note: the "Compile Examples" workflow run for this PR is using the changes I propose here. However, the "Report PR Size Deltas" workflow runs only use the workflow from the default branch of the repository. Because this PR changes the name of the workflow artifact generated by the "Compile Examples" workflow and consumed by the "Report PR Size Deltas" workflow, there will be no size deltas report for this PR. The reports will continue as usual after this PR is merged in to the default branch.

per1234 added 2 commits April 13, 2021 22:58
The "smoke test" sketch compilation and reporting actions have been moved to dedicated repositories. The actions hosted
at the old `arduino/actions/libraries/*` location will no longer be maintained.

Since the time the actions were migrated to the dedicated repositories, a breaking change was made to the default value
of the `sketches-report-path` input, which required a change to the values of the `name` and `path` inputs of the
`actions/upload-artifact` action.
The reliance on the `actions/upload-artifacts` action as the transfer mechanism between workflow runs means that these
values will always be hardcoded into the workflow. The result is that if the default values of the inputs are changed, it
breaks the workflow, even if the changes are synchronized. So it's more robust to avoid dependening on the default
values.
@facchinm facchinm merged commit ae27f37 into arduino:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants