Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleared warnings on platformio for Arduino Uno #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ciband
Copy link

@ciband ciband commented Mar 26, 2018

Cleared warnings on platformio for Arduino Uno

.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp: In static member function 'static uint8_t WiFiDrv::getEncTypeNetowrks(uint8_t)':
C:\Users\chris.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp:451:10: warning: converting to non-pointer type 'uint8_t {aka unsigned char}' from NULL [-Wconversion-null]
return NULL;
^
.....platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp: In static member function 'static int32_t WiFiDrv::getRSSINetoworks(uint8_t)':
.....platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp:476:10: warning: converting to non-pointer type 'int32_t {aka long int}' from NULL [-Wconversion-null]
return NULL;
^

....platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\spi_drv.cpp:22:0:
C:\Users\chris.platformio\packages\framework-arduinoavr\libraries\WiFi\src/utility/spi_drv.h:41:13: warning: 'initialized' defined but not used [-Wunused-variable]
static bool initialized = false;
^

ciband added 2 commits March 26, 2018 10:24
...\.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\spi_drv.cpp:22:0:
C:\Users\chris\.platformio\packages\framework-arduinoavr\libraries\WiFi\src/utility/spi_drv.h:41:13: warning: 'initialized' defined but not used [-Wunused-variable]
static bool initialized = false;
.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp: In static member function 'static uint8_t WiFiDrv::getEncTypeNetowrks(uint8_t)':
C:\Users\chris\.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp:451:10: warning: converting to non-pointer type 'uint8_t {aka unsigned char}' from NULL [-Wconversion-null]
return NULL;
^
....\.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp: In static member function 'static int32_t WiFiDrv::getRSSINetoworks(uint8_t)':
....\.platformio\packages\framework-arduinoavr\libraries\WiFi\src\utility\wifi_drv.cpp:476:10: warning: converting to non-pointer type 'int32_t {aka long int}' from NULL [-Wconversion-null]
return NULL;
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@econeale
Copy link

econeale commented Jun 1, 2021

How does removing the initialized variable impact the WAIT_FOR_SLAVE_SELECT macro? My solution was to add a diagnostic pragma to that line since I don't understand what the macro is doing: #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants