Added a new Example : Servo Stop #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
Mar 21, 2020
There was a problem hiding this comment.
To make the example consistent with the naming convention used in official Arduino examples, please rename the sketch folder and file ServoStop.
Please add a comment containing a short description of the purpose of the sketch and the required circuit. You can check the library's other examples to see the format.
examples/Servo-Stop/Servo-Stop.ino
Outdated
| #define trigPin 4 | ||
| #define echoPin 2 | ||
|
|
||
| Servo myservo; // create servo object to control a servo |
There was a problem hiding this comment.
Suggested change
| Servo myservo; // create servo object to control a servo | |
| Servo myservo; // create Servo object to control a servo |
Use correct class name.
per1234
requested changes
Mar 21, 2020
per1234
previously requested changes
Mar 23, 2020
|
|
per1234
dismissed
their stale review
All significant requested changes have been resolved. Thanks!
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I am Madhur Dixit, a third year student pursuing Bachelors degree in Computer Science and Engineering from Vellore Institute of Technology, Vellore, India.
I am looking forward to making valuable contributions to the Portenta repositories by writing MicroPython examples. Since Portenta board is not released yet I still have practiced with MicroPython on my NodeMCU. I am also planning on porting Arduino examples to Portenta and thus testing my MicroPython example codes on NodeMCU.
You can refer my work till now here:
https://github.com/Chester-King/NodeMCU-Micropython-Examples
Here is a simple PR which adds an example "servo-stop" which depicts the use of Servo with an Ultrasonic sensor. For convenience I have already Auto-Formatted the code.