Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first iteration of WiFiConnectionHandler with Dynamic SSID:PASS pair #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ubidefeo
Copy link
Collaborator

This PR adds a class which supports instantiation without SSID and PASS in order to dynamically set them at later time using setWiFiCredentials(String, String).
This allows a machine to get their WiFi credentials passed in at startup time via means of storage, effectively removing such credentials from the firmware.

@ubidefeo ubidefeo requested a review from aentinger May 22, 2021 10:58
@CLAassistant
Copy link

CLAassistant commented May 22, 2021

CLA assistant check
All committers have signed the CLA.

@ubidefeo
Copy link
Collaborator Author

@aentinger
I found out that I was behind on my local branch with some changes,
have now pulled the upstream, merged into my branch WiFiCredentials-dynamic and pushed again.
Strangely enough my version of Arduino_ConnectionHandler.h was missing the || defined(ARDUINO_NANO_RP2040_CONNECT) but it wasn't showing up in changed files.

It now appears to be aligned, please take a look and let me know if you want me to make changes

u.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants