Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Changing value of property before loop prevents connection to cloud server. #158

Merged

Conversation

aentinger
Copy link
Collaborator

@aentinger aentinger commented Jul 7, 2020

updateTimestampOnLocallyChangedProperties was called before a connection had been established which led to the time service having a wrong date configured (1/1/2000) which leads to an expired certificate which inhibits the establishment of a connection to the server since the certificate has expired. This was triggered when properties where changed within setup.

void setup()
{
  /* ... */
  property = 1337;
  /* This caused updateTimestampOnLocallyChangedProperties to configure the time service
   * before a network connection has been established. This causes a wrong certificate date
   * which appears as if the certificate has expired.
   */
}

Behaviour with the bug present:

Arduino IoT Cloud Connection status: CONNECTING
Arduino IoT Cloud connecting ...
Arduino IoT Cloud connecting ...
Arduino IoT Cloud connecting ...
Arduino IoT Cloud connecting ...
Arduino IoT Cloud connecting ...

@manchoz @zmoog

… a connection had been established which led to the time service having a wrong date configured (1/1/2000) which leads to an expired certificate which inhibits the establishment of a connection to the server since the certificate has expired. This was triggered when properties where changed within 'setup'
@aentinger aentinger added the type: imperfection Perceived defect in any part of project label Jul 7, 2020
@aentinger aentinger self-assigned this Jul 7, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          29       29           
  Lines         998      998           
=======================================
  Hits          954      954           
  Misses         44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd426b4...75bf8c5. Read the comment docs.

@aentinger aentinger merged commit c3d3d4d into master Jul 7, 2020
@aentinger aentinger deleted the fix-changing-property-in-setup-destroys-connection branch July 7, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants