Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to STBTLE-RF and STBTLE-1S module #26

Closed
wants to merge 4 commits into from

Conversation

cparata
Copy link
Contributor

@cparata cparata commented Sep 12, 2019

Hi Sandeep,
I would like to add the support to ST BLE modules (STBTLE-RF and STBTLE-1S) in the ArduinoBLE library. Basically these BLE modules work in coprocessor mode and they are connected to the main MCU via SPI interface. I successfully tested the ArduinoBLE library examples on X-NUCLEO-IDB05A1 shield (that mounts STMTLE-RF module) + a Nucleo board, on B-L475E-IOT01A (that mounts also STMTLE-RF module) and on STEVAL-MKSBOX1V1 (that mounts STMTLE-1S module) using the STM32duino environment. The patch, as you see, should not impact the Arduino boards because it is specific on ST boards, so it should be safe to integrate in the master repo.
Thanks in advance and Best Regards,
Carlo

@cparata cparata force-pushed the master branch 2 times, most recently from d4a80d4 to 2c3a49e Compare September 12, 2019 16:09
@sandeepmistry
Copy link
Contributor

Hi @cparata,

Thanks for opening this! It's great to know that this library at a high level is compatible with STM hardware!

I've discussed this with @mbanzi today, at this time we recommend you/stm32duino maintain a forked version of the library. This would allow your team to more easily provide tech. support for your customers.

We definitely would welcome any pull requests for features or issue fixes in the future.

Please let us know if you have any questions and/or comments on this topic.

@cparata
Copy link
Contributor Author

cparata commented Sep 13, 2019

Hi @sandeepmistry and @mbanzi ,
I understand your point of view and it is reasonable for me. We will create a fork of the ArduinoBLE library in the stm32duino repository. I guess that it will not be difficult to maintain and we can support directly people that want to use ArduinoBLE with ST platforms. I will submit in your official repository any PR that can improve the high level stack. Thanks for the explanation and Best Regards,
Carlo

@cparata cparata force-pushed the master branch 3 times, most recently from c88a490 to 326480b Compare September 18, 2019 07:09
@sandeepmistry
Copy link
Contributor

Hi @cparata,

Thanks for your understanding, once your fork is public please link to it here for others to find in the future. Then I think we can go ahead and close this PR.

@cparata
Copy link
Contributor Author

cparata commented Sep 20, 2019

Hi @sandeepmistry ,
I generated the public fork at the following link:

https://github.com/stm32duino/STM32duinoBLE

Best Regards,
Carlo

README.md Outdated

## License

```
Copyright (c) 2019 Arduino SA. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks.
Done!

@sandeepmistry
Copy link
Contributor

Hi @cparata,

Thanks for the update and the link. For anyone looking to use this library with STM hardware in the future please visit: https://github.com/stm32duino/STM32duinoBLE

I'm going to close this pull request now as we discussed earlier in the thread.

cparata added a commit to cparata/ArduinoBLE that referenced this pull request Feb 8, 2021
Set a bd address from OTP for the BLE device stm32wb55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants