Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix potential arrary overflow problem of _recvBuffer #214

Merged
merged 4 commits into from
Dec 22, 2021
Merged

fix potential arrary overflow problem of _recvBuffer #214

merged 4 commits into from
Dec 22, 2021

Conversation

bigbearishappy
Copy link
Contributor

I find that when I use my nano 33 ble with this BLE lib.
Sometimes when I use the demo project ScanCallback.ino,
my program freezes because of the overflow of _recvBuffer.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@facchinm facchinm requested a review from aentinger December 17, 2021 14:56
aentinger
aentinger requested changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking alright, however a couple of questions remain ...

src/utility/HCI.cpp Outdated Show resolved Hide resolved
src/utility/HCI.cpp Outdated Show resolved Hide resolved
src/utility/HCI.cpp Outdated Show resolved Hide resolved
bigbearishappy and others added 2 commits December 21, 2021 17:50
@bigbearishappy @aentinger
Update src/utility/HCI.cpp
ecfe56a 
make the code eaiser to read

Co-authored-by: Alexander Entinger <[email protected]>
@bigbearishappy
optimize code of potential overflow _recvBuffer
4f4bdd3
aentinger
aentinger reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however you could have left the debug message. (Possibly reinsert it?) I was just critical of the indentation, which seemed too much to me.

@bigbearishappy
Copy link
Contributor Author

LGTM, however you could have left the debug message. (Possibly reinsert it?) I was just critical of the indentation, which seemed too much to me.

Thank you for your reply.It seems that it's better to keep the debug msg.I just restore the code of it.I agree with your suggestion to delete the "continue;".

aentinger
aentinger approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bigbearishappy 🚀

@aentinger aentinger merged commit 8d4d1dc into arduino-libraries:master Dec 22, 2021
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigbearishappy @CLAassistant @aentinger @per1234